From: Avi Kivity <avi@redhat.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: x86@kernel.org, kvm@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86: allow kernel exception fixup for divide errors (#DE)
Date: Tue, 24 Aug 2010 14:39:58 +0300 [thread overview]
Message-ID: <4C73AF8E.60603@redhat.com> (raw)
In-Reply-To: <AANLkTikb1SN6YDsU0dPfTjDkLAZGOX27ccaiEc5OoQHC@mail.gmail.com>
On 08/24/2010 02:22 PM, Brian Gerst wrote:
>
>> +dotraplinkage void do_divide_error(struct pt_regs *regs, long error_code)
>> +{
>> + if (!user_mode_vm(regs)&& fixup_exception(regs))
>> + return;
>> + do_divide_error_user(regs, error_code);
>> +}
>> +
>> #ifdef CONFIG_X86_64
>> /* Runs on IST stack */
>> dotraplinkage void do_stack_segment(struct pt_regs *regs, long error_code)
> Kernel mode exceptions should already be handled by do_trap(). This
> is unnecessary.
Correct. Please ignore this patch. I've verified that the other two
work without it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-24 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 11:10 [PATCH 0/3] Trap and propagate divide errors when emulating DIV Avi Kivity
2010-08-24 11:10 ` [PATCH 1/3] x86: allow kernel exception fixup for divide errors (#DE) Avi Kivity
2010-08-24 11:22 ` Brian Gerst
2010-08-24 11:39 ` Avi Kivity [this message]
2010-08-24 11:10 ` [PATCH 2/3] KVM: x86 emulator: add macros for executing instructions that may trap Avi Kivity
2010-08-24 11:10 ` [PATCH 3/3] KVM: x86 emulator: trap and propagate #DE from DIV and IDIV Avi Kivity
2010-08-25 21:05 ` Marcelo Tosatti
2010-08-26 8:23 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C73AF8E.60603@redhat.com \
--to=avi@redhat.com \
--cc=brgerst@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox