public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: workqueue destruction BUG_ON
Date: Tue, 24 Aug 2010 17:47:33 +0200	[thread overview]
Message-ID: <4C73E995.9030709@kernel.org> (raw)
In-Reply-To: <1282665139.3695.30.camel@jlt3.sipsolutions.net>

Hello,

On 08/24/2010 05:52 PM, Johannes Berg wrote:
> On Tue, 2010-08-24 at 16:56 +0200, Tejun Heo wrote:
>> On 08/24/2010 03:23 PM, Johannes Berg wrote:
>>>> I see, thanks for verifying.  I probably got confused about the line
>>>> number.  Hmm... weird.  I'll prep further debug patch but can you
>>>> please tell me what you did to trigger the bug?
>>>
>>> Not really sure. I think I need to trigger a firmware restart in iwlwifi
>>> and then try to unload the module.
>>
>> Does the following patch fix the problem?
> 
> Not sure. I can't seem to reproduce the exact conditions (firmware
> crash) right now... However I just ran into the WARN_ON_ONCE() your
> previous patch added as well, so that might explain the ath9k problem...

Can you please post the log of the WARN_ON_ONCE()?  That's something
which needs to be fixed from the caller.

Thanks.

-- 
tejun

  reply	other threads:[~2010-08-24 15:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24  8:55 workqueue destruction BUG_ON Johannes Berg
2010-08-24 10:24 ` Tejun Heo
2010-08-24 10:37   ` Johannes Berg
2010-08-24 12:35     ` Tejun Heo
2010-08-24 13:04       ` Johannes Berg
2010-08-24 13:10       ` Johannes Berg
2010-08-24 13:07         ` Tejun Heo
2010-08-24 13:17           ` Johannes Berg
2010-08-24 13:15             ` Tejun Heo
2010-08-24 13:23               ` Johannes Berg
2010-08-24 14:56                 ` Tejun Heo
2010-08-24 15:52                   ` Johannes Berg
2010-08-24 15:47                     ` Tejun Heo [this message]
2010-08-24 15:56                       ` Johannes Berg
2010-08-24 13:19           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C73E995.9030709@kernel.org \
    --to=tj@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox