Sorry, I must have missed the original e-mail. I'll give it a try either later today or tomorrow, after I context-switch back to my dev system that uses the tps6586x driver. - Gary On 08/25/2010 02:53 AM, Liam Girdwood wrote: > > On Mon, 2010-08-23 at 13:09 +0300, Mike Rapoport wrote: > > Mark Brown wrote: > > > On Sun, Aug 22, 2010 at 10:42:42PM +0800, Axel Lin wrote: > > >> The third parameter of tps6586x_set_bits() is the bit_mask, > > >> thus we should use (1 << ri->go_bit) instead of ri->go_bit. > > >> > > >> Signed-off-by: Axel Lin > > > > > > Acked-by: Mark Brown > > > > > > but I'd be much happier if someone who actually has the hardware could > > > verify that this is OK. > > > > I don't have the hardware handy at the moment. > > Gary, can you please verify the fix? > > > > Do we have any news on this testing ? I'd like to have these upstream > for rc3. > > Thanks > > Liam > -- > Freelance Developer, SlimLogic Ltd > ASoC and Voltage Regulator Maintainer. > http://www.slimlogic.co.uk > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I