From: Henrik Rydberg <rydberg@euromail.se>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
pinglinux@gmail.com
Subject: Re: [PATCH v2] input: add multitouch slot support to w8001.
Date: Thu, 26 Aug 2010 08:42:18 +0200 [thread overview]
Message-ID: <4C760CCA.4070403@euromail.se> (raw)
In-Reply-To: <20100826020141.GA24887@barra.bne.redhat.com>
On 08/26/2010 04:01 AM, Peter Hutterer wrote:
> Some serial wacom devices support two-finger touch. Test for this during
> init and parse the touch packets accordingly. Touch packets are
> processed using Protocol B (MT Slots).
>
> Note: there are several wacom versions that do touch but not two-finger
> touch. These are not catered for here, touch events for these are simply
> discarded.
>
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> CC: Henrik Rydberg <rydberg@euromail.se>
> ---
> Changes to v1:
> - model MT slot approach after Henrik's bamboo patches
> - add a comment about what the missing bytes are in the data packets
>
> Henrik, I think this addresses all your comments? The patch is certainly
> a bit simpler now.
Acked-by: Henrik Rydberg <rydberg@euromail.se>
Yes, thanks, it looks fine now. And thanks for finding the bug in my own
version. :-)
Cheers,
Henrik
next prev parent reply other threads:[~2010-08-26 6:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 4:55 [PATCH 0/3] touch tablet support for the w8001 serial driver Peter Hutterer
2010-08-20 4:55 ` [PATCH 1/3] input: send BTN_TOOL_PEN/RUBBER and BTN_STYLUS for the w8001 Peter Hutterer
2010-08-20 4:55 ` [PATCH 2/3] input: support (and ignore) touch tablets in " Peter Hutterer
2010-08-20 4:55 ` [PATCH 3/3] input: add multitouch slot support to w8001 Peter Hutterer
2010-08-23 8:18 ` Henrik Rydberg
2010-08-23 14:11 ` Ping Cheng
2010-08-26 2:01 ` [PATCH v2] " Peter Hutterer
2010-08-26 6:42 ` Henrik Rydberg [this message]
2010-08-29 5:48 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C760CCA.4070403@euromail.se \
--to=rydberg@euromail.se \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox