From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: x86 emulator: trap and propagate #DE from DIV and IDIV
Date: Thu, 26 Aug 2010 11:23:49 +0300 [thread overview]
Message-ID: <4C762495.7050203@redhat.com> (raw)
In-Reply-To: <20100825210501.GD32737@amt.cnet>
On 08/26/2010 12:05 AM, Marcelo Tosatti wrote:
>
>> @@ -3363,7 +3374,7 @@ special_insn:
>> break;
>> case 0xf6 ... 0xf7: /* Grp3 */
>> if (emulate_grp3(ctxt, ops) != X86EMUL_CONTINUE)
>> - goto cannot_emulate;
>> + goto done;
>> break;
> Must assign rc to emulate_grp3() retval.
While there's not much difference between X86EMUL_PROPAGATE_FAULT and
X86EMUL_CONTINUE, it's bad form to break things internally. I'll fix
and repost.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-08-26 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 11:10 [PATCH 0/3] Trap and propagate divide errors when emulating DIV Avi Kivity
2010-08-24 11:10 ` [PATCH 1/3] x86: allow kernel exception fixup for divide errors (#DE) Avi Kivity
2010-08-24 11:22 ` Brian Gerst
2010-08-24 11:39 ` Avi Kivity
2010-08-24 11:10 ` [PATCH 2/3] KVM: x86 emulator: add macros for executing instructions that may trap Avi Kivity
2010-08-24 11:10 ` [PATCH 3/3] KVM: x86 emulator: trap and propagate #DE from DIV and IDIV Avi Kivity
2010-08-25 21:05 ` Marcelo Tosatti
2010-08-26 8:23 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C762495.7050203@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox