From: Tejun Heo <tj@kernel.org>
To: Naohiro Aota <naota@elisp.net>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jiri Kosina <jkosina@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] idr: describe how nextidp works in idr_get_next().
Date: Mon, 30 Aug 2010 17:55:07 +0200 [thread overview]
Message-ID: <4C7BD45B.3050300@kernel.org> (raw)
In-Reply-To: <m2pqx0az4h.fsf@elisp.net>
On 08/30/2010 05:39 PM, Naohiro Aota wrote:
> It was unclear in original kernel-doc how nextidp worked in
> idr_get_next(). Let's describe it.
>
> Signed-off-by: Naohiro Aota <naota@elisp.net>
> ---
> lib/idr.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/lib/idr.c b/lib/idr.c
> index fb86a67..cf8c46b 100644
> --- a/lib/idr.c
> +++ b/lib/idr.c
> @@ -589,7 +589,8 @@ EXPORT_SYMBOL(idr_for_each);
> * @nextidp: pointer to lookup key
> *
> * Returns pointer to registered object with id, which is next number to
> - * given id.
> + * given id. The id pointed by nextidp will be updated
> + * appropriately for next iteration.
> */
Maybe "After being looked up, *@nextidp will be updated for the next
iteration" would be clearer?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-08-30 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 15:37 [PATCH 1/2] idr: fix kernel-doc warnings Naohiro Aota
2010-08-30 15:39 ` [PATCH 2/2] idr: describe how nextidp works in idr_get_next() Naohiro Aota
2010-08-30 15:55 ` Tejun Heo [this message]
2010-08-31 4:02 ` Naohiro Aota
2010-08-31 7:41 ` Tejun Heo
2010-08-31 7:44 ` Jiri Kosina
2010-08-30 15:53 ` [PATCH 1/2] idr: fix kernel-doc warnings Tejun Heo
2010-08-31 7:32 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7BD45B.3050300@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naota@elisp.net \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).