From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754545Ab0IAKDv (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Sep 2010 06:03:51 -0400
Received: from mail-in-01.arcor-online.net ([151.189.21.41]:50759 "EHLO
	mail-in-01.arcor-online.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754049Ab0IAKDt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Sep 2010 06:03:49 -0400
X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-13.arcor-online.net 07A5B212751
Message-ID: <4C7E2501.4050004@arcor.de>
Date: Wed, 01 Sep 2010 12:03:45 +0200
From: Thomas Dahlmann <dahlmann.thomas@arcor.de>
User-Agent: Thunderbird 1.5.0.14 (Windows/20071210)
MIME-Version: 1.0
To: David Brownell <david-b@pacbell.net>
CC: Dan Carpenter <error27@gmail.com>, Julia Lawall <julia@diku.dk>,
        kernel-janitors@vger.kernel.org,
        David Brownell <dbrownell@users.sourceforge.net>,
        Greg Kroah-Hartman <gregkh@suse.de>, linux-geode@lists.infradead.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: Remove double test
References: <634098.18332.qm@web180309.mail.gq1.yahoo.com>
In-Reply-To: <634098.18332.qm@web180309.mail.gq1.yahoo.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

David Brownell schrieb:
> --- On Sat, 8/28/10, Julia Lawall <julia@diku.dk> wrote:
>
>   
>> From: Julia Lawall <julia@diku.dk>
>> Subject: Re: [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: Remove double test
>> To: "Dan Carpenter" <error27@gmail.com>
>> Cc: "Thomas Dahlmann" <dahlmann.thomas@arcor.de>, kernel-janitors@vger.kernel.org, "David Brownell" <dbrownell@users.sourceforge.net>, "Greg Kroah-Hartman" <gregkh@suse.de>, linux-geode@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
>> Date: Saturday, August 28, 2010, 9:48 AM
>> The same expression is tested twice
>> and the result is the same each time.
>> Instead test for use_dma_ppb as in the test above.
>>
>> The sematic match that finds this problem is as follows:
>> (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @expression@
>> expression E;
>> @@
>>
>> (
>> * E
>>   || ... || E
>> |
>> * E
>>   && ... && E
>> )
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <julia@diku.dk>
>>     
>
>
> OK by me unless the maintainer/author objects.
>
> Thank you!
>
> - Dave
>
>   

This fix is OK. Thank you for figuring this out!

- Thomas

>
>   
>> ---
>>  drivers/usb/gadget/amd5536udc.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/amd5536udc.c
>> b/drivers/usb/gadget/amd5536udc.c
>> index 731150d..6c40c99 100644
>> --- a/drivers/usb/gadget/amd5536udc.c
>> +++ b/drivers/usb/gadget/amd5536udc.c
>> @@ -203,7 +203,7 @@ static void print_regs(struct udc
>> *dev)
>>          DBG(dev, "DMA
>> mode       = PPBNDU (packet per
>> buffer "
>>             
>> "WITHOUT desc. update)\n");
>>         
>> dev_info(&dev->pdev->dev, "DMA mode (%s)\n",
>> "PPBNDU");
>> -    } else if (use_dma &&
>> use_dma_ppb_du && use_dma_ppb_du) {
>> +    } else if (use_dma &&
>> use_dma_ppb && use_dma_ppb_du) {
>>          DBG(dev, "DMA
>> mode       = PPBDU (packet per
>> buffer "
>>             
>> "WITH desc. update)\n");
>>         
>> dev_info(&dev->pdev->dev, "DMA mode (%s)\n",
>> "PPBDU");
>>
>>
>>     
>
>