From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
To: "Prashant P. Shah" <pshah.mumbai@gmail.com>
Cc: gregkh@suse.de, randy.dunlap@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
apatard@mandriva.com
Subject: Re: [PATCH] Staging: xgifb: fixed many style issue in vb_ext.c
Date: Wed, 01 Sep 2010 14:36:16 +0200 [thread overview]
Message-ID: <4C7E48C0.8000007@gmail.com> (raw)
In-Reply-To: <1283334498-7490-1-git-send-email-pshah.mumbai@gmail.com>
Il 01/09/2010 11:48, Prashant P. Shah ha scritto:
> This is a patch to the vb_ext.c file that fixes many style
> issues found by the checkpatch.pl tool.
> - extra spaces
> - invalid code indent
> - extra braces
> - invalid comment style
>
> Signed-off-by: Prashant P. Shah<pshah.mumbai@gmail.com>
> ---
> drivers/staging/xgifb/vb_ext.c | 1816 +++++++++++++++++++---------------------
> 1 files changed, 846 insertions(+), 970 deletions(-)
>
> -/* ------------------------------------------------------ */
> -/* Function : XGINew_SenseHiTV */
> -/* Input : */
> -/* Output : */
> -/* Description : */
> -/* ------------------------------------------------------ */
> +/* ----------------------------------------------------------------------------
> + * Function : XGINew_SenseHiTV
> + * Input :
> + * Output :
> + * Description :
> + * ----------------------------------------------------------------------------
> + */
I think you can remove all the banners without meaningful content
instead of making checkpatch happy about them.
thanks,
riccardo
next prev parent reply other threads:[~2010-09-01 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 9:48 [PATCH] Staging: xgifb: fixed many style issue in vb_ext.c Prashant P. Shah
2010-09-01 12:36 ` Riccardo Magliocchetti [this message]
2010-09-01 16:09 ` Prashant Shah
-- strict thread matches above, loose matches on Subject: below --
2010-09-01 16:07 Prashant P. Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7E48C0.8000007@gmail.com \
--to=riccardo.magliocchetti@gmail.com \
--cc=apatard@mandriva.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pshah.mumbai@gmail.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox