From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: [PATCH] KVM: don't sent IPI if the vcpu is not online
Date: Fri, 03 Sep 2010 12:12:03 +0800 [thread overview]
Message-ID: <4C807593.1050903@cn.fujitsu.com> (raw)
It's no need sent IPI to the vcpu which is schedule out
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
include/linux/kvm_host.h | 1 +
virt/kvm/kvm_main.c | 5 ++++-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index f2ecdd5..a2682cf 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -86,6 +86,7 @@ struct kvm_vcpu {
unsigned long requests;
unsigned long guest_debug;
int srcu_idx;
+ bool online;
int fpu_active;
int guest_fpu_loaded, guest_xcr0_loaded;
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 9a73b98..998cbc8 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -148,8 +148,9 @@ static bool make_all_cpus_request(struct kvm *kvm, unsigned int req)
raw_spin_lock(&kvm->requests_lock);
me = smp_processor_id();
kvm_for_each_vcpu(i, vcpu, kvm) {
- if (kvm_make_check_request(req, vcpu))
+ if (kvm_make_check_request(req, vcpu) || !vcpu->online)
continue;
+
cpu = vcpu->cpu;
if (cpus != NULL && cpu != -1 && cpu != me)
cpumask_set_cpu(cpu, cpus);
@@ -2245,6 +2246,7 @@ static void kvm_sched_in(struct preempt_notifier *pn, int cpu)
{
struct kvm_vcpu *vcpu = preempt_notifier_to_vcpu(pn);
+ vcpu->online = true;
kvm_arch_vcpu_load(vcpu, cpu);
}
@@ -2253,6 +2255,7 @@ static void kvm_sched_out(struct preempt_notifier *pn,
{
struct kvm_vcpu *vcpu = preempt_notifier_to_vcpu(pn);
+ vcpu->online = false;
kvm_arch_vcpu_put(vcpu);
}
--
1.7.0.4
next reply other threads:[~2010-09-03 4:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 4:12 Xiao Guangrong [this message]
2010-09-05 7:18 ` [PATCH] KVM: don't sent IPI if the vcpu is not online Avi Kivity
2010-09-06 1:48 ` Xiao Guangrong
2010-09-06 5:46 ` Avi Kivity
2010-09-06 8:51 ` Alexander Graf
2010-09-06 8:55 ` Avi Kivity
2010-09-06 8:59 ` Alexander Graf
2010-09-06 9:05 ` Avi Kivity
2010-09-06 9:09 ` Alexander Graf
2010-09-06 9:14 ` Avi Kivity
2010-09-06 9:19 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C807593.1050903@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox