From: Adrian Hunter <adrian.hunter@nokia.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Tony Lindgren <tony@atomide.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Sundar Iyer <sundar.iyer@stericsson.com>,
Daniel Mack <daniel@caiaq.de>, Pierre Ossman <pierre@ossman.eu>,
Matt Fleming <matt@console-pimps.org>,
David Brownell <dbrownell@users.sourceforge.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Eric Miao <eric.y.miao@gmail.com>,
Cliff Brake <cbrake@bec-systems.com>,
"Lavinen Jarkko (Nokia-MS/Helsinki)" <jarkko.lavinen@nokia.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MMC: move regulator handling closer to core v2
Date: Sat, 04 Sep 2010 09:10:23 +0300 [thread overview]
Message-ID: <4C81E2CF.8070406@nokia.com> (raw)
In-Reply-To: <AANLkTik-uLMUz2g2znaF0K43D8CONsGdjrRqxTCqpS_X@mail.gmail.com>
Linus Walleij wrote:
> 2010/8/31 Linus Walleij <linus.walleij@stericsson.com>:
>
>> After discovering a problem in regulator reference counting I
>> took Mark Brown's advice to move the reference count into the
>> MMC core by making the regulator status a member of
>> struct mmc_host.
>
> This has an Reveiwed-by from the regulator maintainer and
> seems to address all comments, noone is objection so Andrew
> can you pick it up?
One of our contractors had a look at the patch and had this comment:
One comment/question:
/host/mmci.c in function
"static int __devexit mmci_remove(struct amba_device *dev)" there is code:
if (regulator_is_enabled(host->vcc))
regulator_disable(host->vcc);
should "ret = mmc_regulator_set_ocr(mmc, host->vcc, 0);" be added here?
>
> Yours,
> Linus Walleij
>
next prev parent reply other threads:[~2010-09-04 6:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 15:26 [PATCH] MMC: move regulator handling closer to core v2 Linus Walleij
2010-09-03 19:38 ` Linus Walleij
2010-09-04 6:10 ` Adrian Hunter [this message]
2010-09-05 9:05 ` Linus Walleij
2010-09-05 8:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C81E2CF.8070406@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbrake@bec-systems.com \
--cc=daniel@caiaq.de \
--cc=dbrownell@users.sourceforge.net \
--cc=eric.y.miao@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=matt@console-pimps.org \
--cc=pierre@ossman.eu \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=sundar.iyer@stericsson.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox