* apparmor: double lock
@ 2010-09-04 11:57 Jiri Slaby
2010-09-05 5:41 ` John Johansen
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2010-09-04 11:57 UTC (permalink / raw)
To: John Johansen; +Cc: James Morris, LKML
Hi,
stanse found that you possibly double lock ns->lock:
aa_remove_profiles
-> write_lock(&ns->lock)
-> __remove_namespace(ns)
-> destroy_namespace(ns)
-> write_lock(&ns->lock)
Could you fix that if that may happen at all?
regards,
--
js
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: apparmor: double lock
2010-09-04 11:57 apparmor: double lock Jiri Slaby
@ 2010-09-05 5:41 ` John Johansen
2010-09-06 0:29 ` James Morris
0 siblings, 1 reply; 4+ messages in thread
From: John Johansen @ 2010-09-05 5:41 UTC (permalink / raw)
To: Jiri Slaby; +Cc: James Morris, LKML
On 09/04/2010 04:57 AM, Jiri Slaby wrote:
> Hi,
>
> stanse found that you possibly double lock ns->lock:
> aa_remove_profiles
> -> write_lock(&ns->lock)
> -> __remove_namespace(ns)
> -> destroy_namespace(ns)
> -> write_lock(&ns->lock)
>
> Could you fix that if that may happen at all?
>
Yes, thanks Jiri, the patch has already been posted
http://marc.info/?l=linux-kernel&m=128295924407596&w=2
john
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: apparmor: double lock
2010-09-05 5:41 ` John Johansen
@ 2010-09-06 0:29 ` James Morris
2010-09-06 17:13 ` John Johansen
0 siblings, 1 reply; 4+ messages in thread
From: James Morris @ 2010-09-06 0:29 UTC (permalink / raw)
To: John Johansen; +Cc: Jiri Slaby, LKML
On Sat, 4 Sep 2010, John Johansen wrote:
> On 09/04/2010 04:57 AM, Jiri Slaby wrote:
> > Hi,
> >
> > stanse found that you possibly double lock ns->lock:
> > aa_remove_profiles
> > -> write_lock(&ns->lock)
> > -> __remove_namespace(ns)
> > -> destroy_namespace(ns)
> > -> write_lock(&ns->lock)
> >
> > Could you fix that if that may happen at all?
> >
> Yes, thanks Jiri, the patch has already been posted
>
> http://marc.info/?l=linux-kernel&m=128295924407596&w=2
Are all of the patches in that set ready to be merged to Linus?
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: apparmor: double lock
2010-09-06 0:29 ` James Morris
@ 2010-09-06 17:13 ` John Johansen
0 siblings, 0 replies; 4+ messages in thread
From: John Johansen @ 2010-09-06 17:13 UTC (permalink / raw)
To: James Morris; +Cc: Jiri Slaby, LKML
On 09/05/2010 05:29 PM, James Morris wrote:
> On Sat, 4 Sep 2010, John Johansen wrote:
>
>> On 09/04/2010 04:57 AM, Jiri Slaby wrote:
>>> Hi,
>>>
>>> stanse found that you possibly double lock ns->lock:
>>> aa_remove_profiles
>>> -> write_lock(&ns->lock)
>>> -> __remove_namespace(ns)
>>> -> destroy_namespace(ns)
>>> -> write_lock(&ns->lock)
>>>
>>> Could you fix that if that may happen at all?
>>>
>> Yes, thanks Jiri, the patch has already been posted
>>
>> http://marc.info/?l=linux-kernel&m=128295924407596&w=2
>
> Are all of the patches in that set ready to be merged to Linus?
>
yes they should be now, I believe so.
I have just posted out the updated Fix security_task_setrlimit logic
patch that fixes the commenting. I can repost the series if you would
like.
thanks
john
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-06 17:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-04 11:57 apparmor: double lock Jiri Slaby
2010-09-05 5:41 ` John Johansen
2010-09-06 0:29 ` James Morris
2010-09-06 17:13 ` John Johansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox