From: Michael Williamson <michael.williamson@criticallink.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, lrg@slimlogic.co.uk, dtor@mail.ru,
gregkh@suse.de
Subject: Re: [PATCH v1] tps65023: Allow platforms to specify DCDC_2 and DCDC_3 value.
Date: Sun, 05 Sep 2010 07:59:49 -0400 [thread overview]
Message-ID: <4C838635.4090709@criticallink.com> (raw)
In-Reply-To: <20100905085656.GE24817@opensource.wolfsonmicro.com>
On 09/05/2010 04:56 AM, Mark Brown wrote:
> On Sat, Sep 04, 2010 at 02:20:21PM -0400, Michael Williamson wrote:
>
>> This patch allows a platform to pass in the actual voltage used
>> for these DCDC supplies such that they are reported correctly in
>> sysfs.
>
> It's doing this using the constraints rather than through platform data,
> which isn't really idiomatic. It would be better to do this with
> platform data like the fixed voltage regulator does.
>
All right. I will give it another go. Thanks for feedback.
>> Built against 2.6.36-rc3.
>
> It doesn't really matter here but you should always submit patches
> against linux-next.
Understood.
prev parent reply other threads:[~2010-09-05 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 18:20 [PATCH v1] tps65023: Allow platforms to specify DCDC_2 and DCDC_3 value Michael Williamson
2010-09-05 8:56 ` Mark Brown
2010-09-05 11:59 ` Michael Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C838635.4090709@criticallink.com \
--to=michael.williamson@criticallink.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dtor@mail.ru \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox