From: Jason Wessel <jason.wessel@windriver.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Fix typos
Date: Tue, 07 Sep 2010 12:30:18 -0500 [thread overview]
Message-ID: <4C8676AA.9030706@windriver.com> (raw)
In-Reply-To: <20100902121853.e90f6c53.randy.dunlap@oracle.com>
On 09/02/2010 02:18 PM, Randy Dunlap wrote:
> On Thu, 2 Sep 2010 16:05:14 -0300 Lucas De Marchi wrote:
>
>> Hi,
>>
>> I'd like to know if it's worth fixing all typos found in comments,
>> documentation and sometimes code. A first attempt to do that you can
>> find at http://people.profusion.mobi/~lucas/kernel-typos-fix.patch
>>
>> This was done by using the list of common typos available at
>> http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings
>>
>> I already removed some false positives, but there are more. Before
>> going ahead and verifying all of them, I'd like to know whether this
>> would be a good patch.
>
> Hi,
>
> I'd take most of the corrections in Documentation/, but in general,
> I don't think that it's a good idea without some careful review.
I am in agreement with Randy on his point that any changes should get
reviewed if possible by the people who own the files or authored the
comments.
I reviewed all the pieces that were kdb / kgdb related which include
the following and all the changes are ok (one exception noted).
Documentation/kernel-parameters.txt
arch/cris/arch-v32/kernel/kgdb.c
drivers/misc/kgdbts.c
kernel/debug/kdb/kdb_main.c
kernel/debug/kdb/kdb_support.c
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -277,7 +277,7 @@ static int hw_break_release_slot(int breakno)
pevent = per_cpu_ptr(breakinfo[breakno].pev, cpu);
if (dbg_release_bp_slot(*pevent))
/*
- * The debugger is responisble for handing the retry on
+ * The debugger is responsible for handing the retry on
---- from Jason ----
This should actually be:
+ * The debugger is responsible for handling the retry on
--------------------
Thanks,
Jason.
prev parent reply other threads:[~2010-09-07 17:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 19:05 [RFC] Fix typos Lucas De Marchi
2010-09-02 19:18 ` Randy Dunlap
2010-09-02 19:31 ` Lucas De Marchi
2010-09-02 20:00 ` Randy Dunlap
2010-09-02 20:08 ` Lucas De Marchi
2010-09-02 20:13 ` Randy Dunlap
2010-09-02 20:47 ` Lucas De Marchi
2010-09-02 20:16 ` Mike Frysinger
2010-09-02 20:23 ` Lucas De Marchi
2010-09-02 20:25 ` Randy Dunlap
2010-09-02 20:45 ` Lucas De Marchi
2010-09-03 2:29 ` Phillip Lougher
2010-09-03 2:45 ` Lucas De Marchi
2010-09-03 5:20 ` Lucas De Marchi
2010-09-03 5:23 ` Lucas De Marchi
2010-09-02 19:32 ` Mike Frysinger
2010-09-03 2:17 ` Phillip Lougher
2010-09-07 16:06 ` Paul E. McKenney
2010-09-07 16:47 ` Len Brown
2010-09-07 17:01 ` Lucas De Marchi
2010-09-07 17:30 ` Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8676AA.9030706@windriver.com \
--to=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox