Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped

Ingo Molnar
2010-09-03T06:39:47Z

* Andi Kleen <andi@firstfloor.org> wrote:

> > This isnt a particularly useful solution to users of said systems -
> > they have to figure out that this option exists, and then they have
> > to enter this option on the boot line.
>
> This usually only happens in early preproduction systems. So far the
> BIOS always got fixed before they shipped to users.

'Usually' != 'always'. Read the changelog:

' There are BIOSes in production that have these failures, so this will
allow people in the field to work around these BIOS issues. '

Peter, which system in production that has this problem? That one needs
a DMI match.

Preproduction systems can certainly be hacked around with the boot
option and are not worth the DMI match. (preproduction systems also tend
to have have very unspecific DMI strings in most cases - things like
'1234567890' or 'to be filled by OEM')

In important cases a PCI ID match can be done for serious bugs in
widespread preproduction systems - we have a handful of examples in-tree
for such workarounds - but i doubt this is such a case - we use it for
crasher bugs, not for 'boots up slow' cases.

Nevertheless, production systems need a DMI match.

Thanks,

Ingo