From: Michal Marek <mmarek@suse.cz>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
bebarino@gmail.com
Subject: Re: [PATCH] nconfig: Fix help for choice menus
Date: Mon, 13 Sep 2010 12:43:57 +0200 [thread overview]
Message-ID: <4C8E006D.6020706@suse.cz> (raw)
In-Reply-To: <AANLkTimy0Ygv6rtL7MA+Lf5_AX5F-VFiDeJZ7GMLbLia@mail.gmail.com>
On 12.9.2010 10:06, Nir Tzachar wrote:
> On Fri, Sep 10, 2010 at 11:32 AM, Stephen Boyd <bebarino@gmail.com> wrote:
>> When getting the help for a choice menu with a help section (for example
>> the "Choose SLAB allocator" menu) nconfig pops up a window with nothing
>> inside it. This is due to show_help() passing an empty string to
>> show_scroll_win()'s 3rd argument. The option really does have help
>> though, but it isn't a config symbol, so just add the help text for
>> the option, and don't try to add anything else like the config option
>> name.
>
>
> Acked-by: Nir Tzachar <nir.tzachar@gmail.com>
Thanks, applied.
Michal
prev parent reply other threads:[~2010-09-13 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 8:32 [PATCH] nconfig: Fix help for choice menus Stephen Boyd
2010-09-12 8:06 ` Nir Tzachar
2010-09-13 10:43 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8E006D.6020706@suse.cz \
--to=mmarek@suse.cz \
--cc=bebarino@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.tzachar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox