From: Jiri Slaby <jslaby@suse.cz>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: phil@ipom.com, stable@kernel.org, Greg KH <gregkh@suse.de>,
USB list <linux-usb@vger.kernel.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [34-stable regression] USB delay init quirk causes device events loss
Date: Mon, 13 Sep 2010 16:23:10 +0200 [thread overview]
Message-ID: <4C8E33CE.4010105@suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1009131014460.1584-100000@iolanthe.rowland.org>
On 09/13/2010 04:16 PM, Alan Stern wrote:
> On Mon, 13 Sep 2010, Jiri Slaby wrote:
>> The problem is that the patch shuffles with usb_detect_quirks which used
>> to disable autosuspend by default. Apparently it no longer does.
>
> I don't see how that patch could have the effect you claim.
> usb_detect_quirks still calls usb_disable_autosuspend. Can you do a
> little more debugging to find out why it isn't working as expected?
> Reverting the commit is not a good solution.
Ok, I could, but I have a near-zero knowledge about usb core stuff. What
I see is that usb_detect_quirks moved from usb_new_device to
hub_port_connect_change. Might that be that there are broken devices
which doesn't generate state changes properly?
In other words, what I could do is to add some printks into
hub_port_connect_change if that's called at all. If you need some
thorough debugging printks, please send me a patch to test instead.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2010-09-13 14:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 11:18 [34-stable regression] USB delay init quirk causes device events loss Jiri Slaby
2010-09-13 14:16 ` Alan Stern
2010-09-13 14:23 ` Jiri Slaby [this message]
2010-09-13 14:48 ` Alan Stern
2010-09-13 14:59 ` Jiri Slaby
2010-09-13 15:37 ` Alan Stern
2010-09-13 15:56 ` Greg KH
2010-09-13 16:02 ` Phil Dibowitz
2010-09-13 16:24 ` Alan Stern
2010-09-13 17:03 ` Jiri Slaby
2010-09-13 17:06 ` Greg KH
2010-09-14 12:03 ` Oliver Neukum
2010-09-14 14:03 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8E33CE.4010105@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=phil@ipom.com \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox