[RFC PATCH] x86: don't compile with gcc-3.3.3

florian
2010-09-13T08:33:54Z

hpa commented on bug 16506[1] :
"Please note that gcc-3.3.3 is known broken on x86; gcc-3.4 is the oldest
version which is known to *not* be broken."

References:
[0]: https://bugzilla.kernel.org/show_bug.cgi?id=16633
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=16506#c28

If that is indeed so, we should abort the build? No?

---
arch/x86/Makefile | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 8aa1b59..1eb2d99 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -153,7 +153,7 @@ all: bzImage
# KBUILD_IMAGE specify target image being built
KBUILD_IMAGE := $(boot)/bzImage

-bzImage: vmlinux
+bzImage: checkgccversion vmlinux
ifeq ($(CONFIG_X86_DECODER_SELFTEST),y)
$(Q)$(MAKE) $(build)=arch/x86/tools posttest
endif
@@ -172,6 +172,12 @@ PHONY += vdso_install
vdso_install:
$(Q)$(MAKE) $(build)=arch/x86/vdso $@

+checkgccversion:
+ $(Q)if test "$(call cc-fullversion)" = "040403" ; then \
+ echo "*** GCC-3.3.3 is known broken. Please upgrade." ; \
+ echo "*** GCC-3.4 is the earliest version known *not* broken." ; \
+ false ; \
+ fi
archclean:
$(Q)rm -rf $(objtree)/arch/i386
$(Q)rm -rf $(objtree)/arch/x86_64
--
1.7.2