Re: [PATCH v3] mfd: tps6586x: add basic interrupt support

Samuel Ortiz
2010-09-15T11:32:23Z

On Wed, Sep 15, 2010 at 12:55:34PM +0200, Samuel Ortiz wrote:
> Hi Gary,
>
> On Mon, Sep 13, 2010 at 06:37:42PM -0700, Gary King wrote:
> > Hi Samuel, Mike,
> >
> > This patch incorporates Mike's feedback to my v2 patch to add interrupt
> > support to the tps6586x driver.
> >
> > Changes since v2:
> > * Remove stale comment in commit message
> >
> > Changes since v1:
> > * Move the interrupt enum ordering to match the ACK register values
> >
> > * Treat the INT_ACK registers as a single 32b unsigned int.
> >
> > * Name and define all the interrupts on the device
> >
> > * If reading the ACK registers in the interrupt thread fails, IRQ_NONE
> > is returned, rather than disabling the IRQ handler. This fixes
> > interrupts following suspend.
> >
> > * The cascaded IRQ is passed through the i2c_client's .irq field, rather
> > than through platform data.
> Patch applied, many thanks.
...with this build fix:

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 01c928b..385cc38 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -563,8 +563,8 @@ config MFD_JZ4740_ADC
This driver is necessary for jz4740-battery and jz4740-hwmon driver.

config MFD_TPS6586X
- tristate "TPS6586x Power Management chips"
- depends on I2C && GPIOLIB
+ bool "TPS6586x Power Management chips"
+ depends on I2C && GPIOLIB && GENERIC_HARDIRQS
select MFD_CORE
help
If you say yes here you get support for the TPS6586X series of

Cheers,
Samuel.

--
Intel Open Source Technology Centre