Re: [PATCH v3] mfd: tps6586x: add basic interrupt support

Samuel Ortiz
2010-09-15T10:55:15Z

Hi Gary,

On Mon, Sep 13, 2010 at 06:37:42PM -0700, Gary King wrote:
> Hi Samuel, Mike,
>
> This patch incorporates Mike's feedback to my v2 patch to add interrupt
> support to the tps6586x driver.
>
> Changes since v2:
> * Remove stale comment in commit message
>
> Changes since v1:
> * Move the interrupt enum ordering to match the ACK register values
>
> * Treat the INT_ACK registers as a single 32b unsigned int.
>
> * Name and define all the interrupts on the device
>
> * If reading the ACK registers in the interrupt thread fails, IRQ_NONE
> is returned, rather than disabling the IRQ handler. This fixes
> interrupts following suspend.
>
> * The cascaded IRQ is passed through the i2c_client's .irq field, rather
> than through platform data.
Patch applied, many thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre