From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752369Ab0ING6d (ORCPT ); Tue, 14 Sep 2010 02:58:33 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:44601 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389Ab0ING6c (ORCPT ); Tue, 14 Sep 2010 02:58:32 -0400 Message-ID: <4C8F1D16.3040109@kernel.dk> Date: Tue, 14 Sep 2010 08:58:30 +0200 From: Jens Axboe MIME-Version: 1.0 To: Stefan Richter CC: Andrew Morton , Florian Mickler , linux-kernel@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [Bug 18252] spinlock lockup in __make_request <- submit_bio <- ondemand_readahead References: <4C8B50F1.4020502@s5r6.in-berlin.de> <20100913144139.b9e18133.akpm@linux-foundation.org> <4C8F1CAB.7020004@s5r6.in-berlin.de> In-Reply-To: <4C8F1CAB.7020004@s5r6.in-berlin.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2010-09-14 08:56, Stefan Richter wrote: > Andrew Morton wrote: >>>> https://bugzilla.kernel.org/show_bug.cgi?id=18252 > ... >> What you've quoted above appears to be just the aftermath. >> https://bugzilla.kernel.org/attachment.cgi?id=29562 indicates that the >> kernel earlier crashed in scsi code, perhaps under >> scsi_setup_fs_cmnd(). >> >> The question is: was that actually the first crash, or did an even >> earlier one scroll off? > > It happened overnight. The screenshot > https://bugzilla.kernel.org/attachment.cgi?id=29562 shows that there was a lot > more logged before it. When I saw it in the morning I assumed that the tail > was a repetition of the leading bug trace, but it seems I am mistaken. > > Florian Mickler wrote: >> There was an scsi-related use-after-free OOPS fixed recently and pulled 3 days >> ago. >> >> On Sat, 11 Sep 2010 19:07:44 +0000 >> James Bottomley wrote: >> >>> This includes the oops from use after free, a set of qla2xxx fixes, some >>> misc warning cleanups from the recently introduced printk issue, an hpsa >>> lockup fix and a medium removal bug in sd introduced by the BKL >>> pushdown. >>> >>> The patch is available here: >>> >>> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git >> >> Maybe you are seeing that? >> >> (reacting to the general-protection-fault preceded by scsi_init in the >> attachment jpg) > > Now that you point it out --- perhaps. Though I haven't looked into the > mechanics of the now fixed scsi_ini_io use after free. It seems the very likely explanation, since I can't see any other way that you would deadlock on the queue lock from that call trace if you haven't had someone else crash with the lock held already. -- Jens Axboe