From: Tejun Heo <tj@kernel.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: lockdep warning: events vs. bd_mutex
Date: Tue, 14 Sep 2010 09:49:52 +0200 [thread overview]
Message-ID: <4C8F2920.3000508@kernel.org> (raw)
In-Reply-To: <20100914160729.C9A1.A69D9226@jp.fujitsu.com>
Hello,
On 09/14/2010 09:27 AM, KOSAKI Motohiro wrote:
> lru_add_drain_all() wait system_wq.
>
> Probably we have four choice.
> 1) simple revert buggy patch (I don't know how much serious original issue)
> 2) ata_scsi_dev_rescan() doesn't use system_wq
> 3) lru_add_drain_all() doesn't use system_wq
> 4) make IPI version lru_add_drain_all()
>
> I'd like to hear Tejun's opinion.
Yeah, it was reported before. The warning is bogus at this point.
The right thing to do would be improving lockdep annotation in
workqueue code but for now the easiest way out would be simply using
one of other system workqueues. I'll look into it.
Thanks.
--
tejun
prev parent reply other threads:[~2010-09-14 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 20:43 lockdep warning: events vs. bd_mutex Arnd Bergmann
2010-09-14 7:27 ` KOSAKI Motohiro
2010-09-14 7:49 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8F2920.3000508@kernel.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox