From: Phil Turmel <philip@turmel.org>
To: Francisco Jerez <currojerez@riseup.net>
Cc: linux-kernel@vger.kernel.org, "Ben Skeggs" <bskeggs@redhat.com>,
"Matthew Garrett" <mjg@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Marcin Kos'cielnicki" <koriakin@0x04.net>,
"Dave Airlie" <airlied@redhat.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] nouveau build regression, undefined reference to `acpi_video_get_edid'
Date: Tue, 14 Sep 2010 09:59:59 -0400 [thread overview]
Message-ID: <4C8F7FDF.6090904@turmel.org> (raw)
In-Reply-To: <87hbhslatm.fsf@riseup.net>
Francisco Jerez wrote:
> Phil Turmel <philip@turmel.org> writes:
[snip /]
>> Having the nouveau ACPI features depend on CONFIG_ACPI_VIDEO instead of
>> bare CONFIG_ACPI builds, boots, and works for me.
> nouveau_acpi_edid() is the only function that depends on ACPI_VIDEO,
> ifdef'ing out the rest of the ACPI stuff in that case doesn't make much
> sense to me.
Understood. I noticed that DRM_I915 does a "select ACPI_VIDEO if ACPI",
which is why I mentioned that alternative below. I don't recall how I got
the y+m combination above (I tend to build stuff in), but a randconfig
could certainly hit this. I intend to leave it y+y when I'm done.
>> Presumably, this could also be solved by adding
>> "select ACPI_VIDEO if ACPI" to the nouveau Kconfig.
>> I'd be happy to try that, if this approach is flawed.
I'll test the Kconfig approach later today.
Regards,
Phil Turmel
next prev parent reply other threads:[~2010-09-14 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 3:53 [PATCH] nouveau build regression, undefined reference to `acpi_video_get_edid' Phil Turmel
2010-09-14 13:21 ` Francisco Jerez
2010-09-14 13:59 ` Phil Turmel [this message]
2010-09-15 0:14 ` [PATCH v2] " Phil Turmel
2010-09-17 3:39 ` Francisco Jerez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8F7FDF.6090904@turmel.org \
--to=philip@turmel.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=currojerez@riseup.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=koriakin@0x04.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox