From: Phil Turmel <philip@turmel.org>
To: Francisco Jerez <currojerez@riseup.net>
Cc: linux-kernel@vger.kernel.org, Ben Skeggs <bskeggs@redhat.com>,
Matthew Garrett <mjg@redhat.com>, David Airlie <airlied@linux.ie>,
"Marcin Kos'cielnicki" <koriakin@0x04.net>,
Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v2] nouveau build regression, undefined reference to `acpi_video_get_edid'
Date: Tue, 14 Sep 2010 20:14:11 -0400 [thread overview]
Message-ID: <4C900FD3.80500@turmel.org> (raw)
In-Reply-To: <4C8F7FDF.6090904@turmel.org>
Build breakage:
drivers/built-in.o: In function `nouveau_acpi_edid':
(.text+0x13404e): undefined reference to `acpi_video_get_edid'
make: *** [.tmp_vmlinux1] Error 1
Introduced by:
a6ed76d7ffc62ffa474b41d31b011b6853c5de32 is the first bad commit
commit a6ed76d7ffc62ffa474b41d31b011b6853c5de32
Author: Ben Skeggs <bskeggs@redhat.com>
Date: Mon Jul 12 15:33:07 2010 +1000
drm/nouveau: support fetching LVDS EDID from ACPI
Based on a patch from Matthew Garrett.
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Acked-by: Matthew Garrett <mjg@redhat.com>
:040000 040000 2fbe9b4d9778329908107e72c11b100c2f5a460b 97dcf06923bb576298746584c45d17d3be9edcf8 M drivers
It doesn't seem to revert cleanly, but the problem lies in these
two config entries:
CONFIG_ACPI=y
CONFIG_ACPI_VIDEO=m
Adding a select for ACPI_VIDEO appears to be the best solution, and
is comparable to what is done in DRM_I915. Builds, boots, and appears to
work correctly.
Signed-off-by: Philip J. Turmel <philip@turmel.org>
---
The first version disabled all ACPI functions in the nouveau driver if
ACPI_VIDEO wasn't set. Francisco Jerez <currojerez@riseup.net> pointed out
that this didn't make much sense.
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index d2d2804..72730e9 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -10,6 +10,7 @@ config DRM_NOUVEAU
select FB
select FRAMEBUFFER_CONSOLE if !EMBEDDED
select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT
+ select ACPI_VIDEO if ACPI
help
Choose this option for open-source nVidia support.
next prev parent reply other threads:[~2010-09-15 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 3:53 [PATCH] nouveau build regression, undefined reference to `acpi_video_get_edid' Phil Turmel
2010-09-14 13:21 ` Francisco Jerez
2010-09-14 13:59 ` Phil Turmel
2010-09-15 0:14 ` Phil Turmel [this message]
2010-09-17 3:39 ` [PATCH v2] " Francisco Jerez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C900FD3.80500@turmel.org \
--to=philip@turmel.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=currojerez@riseup.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=koriakin@0x04.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox