From: Sergei Shtylyov <sshtylyov@mvista.com>
To: balbi@ti.com
Cc: Ming Lei <tom.leiming@gmail.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
"greg@kroah.com" <greg@kroah.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Brownell <dbrownell@users.sourceforge.net>,
"Gadiyar, Anand" <gadiyar@ti.com>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [Discussion] USB: musb-gadget: how to fix ZLP issue in musb_g_tx
Date: Wed, 15 Sep 2010 17:10:15 +0400 [thread overview]
Message-ID: <4C90C5B7.7050103@ru.mvista.com> (raw)
In-Reply-To: <20100915110745.GP3393@legolas.emea.dhcp.ti.com>
Hello.
Felipe Balbi wrote:
> On Wed, Sep 15, 2010 at 06:02:22AM -0500, Ming Lei wrote:
>> If so, once the dma interrupt comes, will request->actual be same
>> with request->length in musb_g_tx? And if it is true, could we remove
>> the
>> check for 'is_dma'?
> see that is_dma is set to true by just checking if dma in enabled in
> txcsr, it might be that dma didn't complete everything and you need to
> write txpktrdy by hand to send last short packet. So to remove that you
> would need to re-work a bit more code.
I don't see what to rework. The last short packet should still satisfy
(request->actual == request->length) condition, no?
> You need to know when this is a dma IRQ or an endpoint IRQ.
We know that -- but why check it there, before (request->actual ==
request->length)?
WBR, Sergei
next prev parent reply other threads:[~2010-09-15 13:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 10:53 [Discussion] USB: musb-gadget: how to fix ZLP issue in musb_g_tx Ming Lei
2010-09-15 10:56 ` Felipe Balbi
2010-09-15 11:02 ` Ming Lei
2010-09-15 11:07 ` Felipe Balbi
2010-09-15 13:10 ` Sergei Shtylyov [this message]
2010-09-16 6:05 ` Felipe Balbi
2010-09-16 6:15 ` Gadiyar, Anand
2010-09-16 6:22 ` Felipe Balbi
2010-09-16 6:54 ` Ming Lei
2010-09-16 11:03 ` Sergei Shtylyov
2010-09-15 11:14 ` Ming Lei
2010-09-15 13:06 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C90C5B7.7050103@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=balbi@ti.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gadiyar@ti.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox