From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755103Ab0ISQxy (ORCPT ); Sun, 19 Sep 2010 12:53:54 -0400 Received: from mx01.sz.bfs.de ([194.94.69.103]:60477 "EHLO mx01.sz.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755020Ab0ISQxx (ORCPT ); Sun, 19 Sep 2010 12:53:53 -0400 Message-ID: <4C96401C.1000707@bfs.de> Date: Sun, 19 Sep 2010 18:53:48 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: Vasiliy Kulikov CC: kernel-janitors@vger.kernel.org, James Bottomley , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/14] mca: fix device_register() error handling References: <1284900887-24327-1-git-send-email-segooon@gmail.com> In-Reply-To: <1284900887-24327-1-git-send-email-segooon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vasiliy Kulikov schrieb: > If device_register() fails then call put_device(). > See comment to device_register. > > Signed-off-by: Vasiliy Kulikov > --- > I cannot compile this driver, so it is not tested at all. > > drivers/mca/mca-bus.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/mca/mca-bus.c b/drivers/mca/mca-bus.c > index ada5ebb..7162f08 100644 > --- a/drivers/mca/mca-bus.c > +++ b/drivers/mca/mca-bus.c > @@ -116,8 +116,10 @@ int __init mca_register_device(int bus, struct mca_device *mca_dev) > mca_dev->dev.coherent_dma_mask = mca_dev->dma_mask; > > rc = device_register(&mca_dev->dev); > - if (rc) > + if (rc) { > + put_device(&mca_dev->dev); > goto err_out; > + } > > rc = device_create_file(&mca_dev->dev, &dev_attr_id); > if (rc) goto err_out_devreg; > @@ -154,6 +156,7 @@ struct mca_bus * __devinit mca_attach_bus(int bus) > dev_set_name(&mca_bus->dev, "mca%d", bus); > sprintf(mca_bus->name,"Host %s MCA Bridge", bus ? "Secondary" : "Primary"); > if (device_register(&mca_bus->dev)) { > + put_device(&mca_bus->dev); > kfree(mca_bus); > return NULL; > } just a minor: dev_set_name() is not check here. (But is in other places). re, wh