From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 2/2] x86, CPUID: Correct operator precedence when generating mask
Date: Mon, 20 Sep 2010 08:11:43 -0700 [thread overview]
Message-ID: <4C9779AF.8080303@zytor.com> (raw)
In-Reply-To: <20100920140621.GA4920@aftab>
On 09/20/2010 07:06 AM, Borislav Petkov wrote:
> NEED_<cpufeature> masks used in the CPU feature testing macros are
> cutoff at the last 5 bits to prevent overflow since the cpu feature
> words are 32-bit-wide bitfields. Fix this for the PSE and PGE masks too.
>
> This wasn't a real problem since the PSE and PGE bits are nicely < 31.
>
> Cc: stable@kernel.org
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Since this is a non-manifest bug there really doesn't seem to be any
reason to bother stable with it.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-09-20 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 14:06 [PATCH 2/2] x86, CPUID: Correct operator precedence when generating mask Borislav Petkov
2010-09-20 15:11 ` H. Peter Anvin [this message]
2010-09-21 12:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9779AF.8080303@zytor.com \
--to=hpa@zytor.com \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox