From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@amd64.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 1/2] x86, cpuid: Unbreak CPB CPUID feature
Date: Mon, 20 Sep 2010 08:25:59 -0700 [thread overview]
Message-ID: <4C977D07.7030506@zytor.com> (raw)
In-Reply-To: <20100920152025.GA4999@aftab>
On 09/20/2010 08:20 AM, Borislav Petkov wrote:
> From: "H. Peter Anvin" <hpa@zytor.com>
> Date: Mon, Sep 20, 2010 at 11:10:49AM -0400
>
>> On 09/20/2010 07:05 AM, Borislav Petkov wrote:
>>> 5958f1d5d722df7a9e5d129676614a8e5219bacd added mistakenly the CPB bit to
>>> the common scattered CPUID features. Move it to AMD-only code where it
>>> belongs.
>>
>> I already asked for more information about this.
>
> ?? When? I prepped this one a couple of hours ago... Am I missing something?
>
Looks like Bugzilla didn't register the reply. I have resent it.
>> This patch, without a further description, makes absolutely no sense,
>> and is furthermore implemented poorly -- I really don't want more ad
>> hoc code if it can be avoided.
>
> Well, I use the feature bit in powernow-k8.c. We don't need to advertize
> it in /proc/cpuinfo per se if that's what you prefer?
No, I'm asking why it's being moved away from the common area -- I don't
see any evidence that it causes the reported failure scenario, and it
complicates the code needlessly.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2010-09-20 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 14:05 [PATCH 1/2] x86, cpuid: Unbreak CPB CPUID feature Borislav Petkov
2010-09-20 15:10 ` H. Peter Anvin
2010-09-20 15:20 ` Borislav Petkov
2010-09-20 15:25 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C977D07.7030506@zytor.com \
--to=hpa@zytor.com \
--cc=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox