From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756686Ab0ITP01 (ORCPT ); Mon, 20 Sep 2010 11:26:27 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43773 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644Ab0ITP00 (ORCPT ); Mon, 20 Sep 2010 11:26:26 -0400 Message-ID: <4C977D07.7030506@zytor.com> Date: Mon, 20 Sep 2010 08:25:59 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Borislav Petkov CC: Ingo Molnar , Thomas Gleixner , LKML , x86 Subject: Re: [PATCH 1/2] x86, cpuid: Unbreak CPB CPUID feature References: <20100920140521.GA4823@aftab> <4C977979.2060301@zytor.com> <20100920152025.GA4999@aftab> In-Reply-To: <20100920152025.GA4999@aftab> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2010 08:20 AM, Borislav Petkov wrote: > From: "H. Peter Anvin" > Date: Mon, Sep 20, 2010 at 11:10:49AM -0400 > >> On 09/20/2010 07:05 AM, Borislav Petkov wrote: >>> 5958f1d5d722df7a9e5d129676614a8e5219bacd added mistakenly the CPB bit to >>> the common scattered CPUID features. Move it to AMD-only code where it >>> belongs. >> >> I already asked for more information about this. > > ?? When? I prepped this one a couple of hours ago... Am I missing something? > Looks like Bugzilla didn't register the reply. I have resent it. >> This patch, without a further description, makes absolutely no sense, >> and is furthermore implemented poorly -- I really don't want more ad >> hoc code if it can be avoided. > > Well, I use the feature bit in powernow-k8.c. We don't need to advertize > it in /proc/cpuinfo per se if that's what you prefer? No, I'm asking why it's being moved away from the common area -- I don't see any evidence that it causes the reported failure scenario, and it complicates the code needlessly. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.