Re: [PATCH 08/10] jump label v11: x86 support

Jason Baron
2010-09-21T15:26:27Z

On Mon, Sep 20, 2010 at 07:43:16PM -0700, H. Peter Anvin wrote:
> On 09/17/2010 08:09 AM, Jason Baron wrote:
> > add x86 support for jump label. I'm keeping this patch separate so its clear to
> > arch maintainers what was required for x86 support this new feature. hopefully,
> > it wouldn't be too painful for other arches.
>
> > + select HAVE_ARCH_JUMP_LABEL if !CC_OPTIMIZE_FOR_SIZE
>
> Why?
>
> -hpa
>

Hi,

>From the documentation patch:

"
The optimization depends on !CC_OPTIMIZE_FOR_SIZE. When CC_OPTIMIZE_FOR_SIZE is
set, gcc does not always out of line the not taken label path in the same way
that the "if unlikely()" paths are made out of line. Thus, with
CC_OPTIMIZE_FOR_SIZE set, this optimization is not always optimal. This may be
solved in subsequent gcc versions, that allow us to move labels out of line,
while still optimizing for size.
"

This was also discuessed a bit on lkml previously:

http://marc.info/?l=linux-kernel&m=127618233108964&w=2

thanks,

-Jason