From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756785Ab0IUIPn (ORCPT ); Tue, 21 Sep 2010 04:15:43 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:47380 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756346Ab0IUIPk (ORCPT ); Tue, 21 Sep 2010 04:15:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=Vu8roeNjNHCnWJLdYYslSLLTkCHhWaMgrdDiX5LOrV2PPAwvKpWzrZ2CowyjhuIlYn zL8NLQhKSMVkt8VgQz1psEB7EYXg+AkmJS1BxqEn90SEDTfC8tSHBvmc6zxQeNXGD4sK l70aN10XZVyeFXavFJvvFK7TfU0TOjICc+iRM= Message-ID: <4C986A09.3080808@gmail.com> Date: Tue, 21 Sep 2010 10:17:13 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.9) Gecko/20100915 Lightning/1.0b2 Thunderbird/3.1.4 MIME-Version: 1.0 To: Michael Tokarev CC: Jeff Garzik , Pedro Francisco , linux-kernel@vger.kernel.org, "linux-ide@vger.kernel.org" Subject: Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split References: <201009162256.04765.pedrogfrancisco@gmail.com> <47010.148.87.67.141.1284674336.squirrel@www.xenotime.net> <4C933A8F.2080305@gmail.com> <1284892106.2650.4.camel@sundae-v2> <4C9602E4.4090007@gmail.com> <1284974726.11757.9.camel@sundae-v2> <4C9729D7.70500@gmail.com> <4C972C60.8010506@gmail.com> <1285015465.26023.10.camel@sundae-v2> <4C97DB80.4060403@gmail.com> <4C97DBE2.8070707@gmail.com> <4C984D44.1080109@msgid.tls.msk.ru> <4C985DFC.7020203@gmail.com> <4C985F88.1010501@msgid.tls.msk.ru> In-Reply-To: <4C985F88.1010501@msgid.tls.msk.ru> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2010 09:32 AM, Michael Tokarev wrote: > 21.09.2010 11:25, Tejun Heo wrote: >> libata depends on scsi_host_template for module reference counting and >> sht's should be owned by each low level driver. During libahci split, >> the sht was left with libahci.ko leaving the actual low level drivers >> not reference counted. This made ahci and ahci_platform always >> unloadable even while they're being actively used. >> >> Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for >> each low level ahci driver. >> >> stable: only applicable to 2.6.35. >> >> Signed-off-by: Tejun Heo >> Reported-by: Michael Tokarev >> Cc: stable@kernel.org >> --- >> Michael, thanks a lot for spotting it and bearing with me. > Um. All thanks goes to Pedro Francisco please, not to me - > I just verified your patch on my system, it was Pedro who spotted > and reported this. You may add my > > Tested-Off-By: Michael Tokarev > > , but not Reported-by... please ;) Oh, right. Jeff, can you please adjust tags to Reported-by: Pedro Francisco Tested-by: Michael Tokarev Thanks. -- tejun