* [PATCH 13/14] uwb: fix device_register() error handling
@ 2010-09-19 12:55 Vasiliy Kulikov
2010-09-22 11:36 ` David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-09-19 12:55 UTC (permalink / raw)
To: kernel-janitors; +Cc: David Vrabel, Tejun Heo, linux-usb, linux-kernel
If device_register() fails then call put_device().
See comment to device_register.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
compile tested.
drivers/uwb/umc-dev.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/uwb/umc-dev.c b/drivers/uwb/umc-dev.c
index 43ea998..e8e06ee 100644
--- a/drivers/uwb/umc-dev.c
+++ b/drivers/uwb/umc-dev.c
@@ -68,6 +68,7 @@ int umc_device_register(struct umc_dev *umc)
return 0;
error_device_register:
+ put_device(&umc->dev);
release_resource(&umc->resource);
error_request_resource:
return err;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 13/14] uwb: fix device_register() error handling
2010-09-19 12:55 [PATCH 13/14] uwb: fix device_register() error handling Vasiliy Kulikov
@ 2010-09-22 11:36 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2010-09-22 11:36 UTC (permalink / raw)
To: Vasiliy Kulikov; +Cc: kernel-janitors, Tejun Heo, linux-usb, linux-kernel
Vasiliy Kulikov wrote:
> If device_register() fails then call put_device().
> See comment to device_register.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: David Vrabel <david.vrabel@csr.com>
What's the preferred way of handling these sorts of patch sets? Merged
via some kernel-janitor tree or is it expected that subsystem
maintainers pick up the individual patches?
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-22 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-19 12:55 [PATCH 13/14] uwb: fix device_register() error handling Vasiliy Kulikov
2010-09-22 11:36 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox