* [PATCH] mfd: Declare abx500_remove_ops()
@ 2010-09-22 13:58 Mark Brown
2010-09-22 14:22 ` Mattias Wallin
2010-09-27 13:29 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-22 13:58 UTC (permalink / raw)
To: Samuel Ortiz, Mattias Wallin, Linus Walleij
Cc: linux-kernel, patches, Mark Brown
Otherwise sparse warns about a public symbol with no declaration and
the compiler can't spot if the callers and users have different signatures
for the function.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
include/linux/mfd/abx500.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
index be7373c..67bd6f7 100644
--- a/include/linux/mfd/abx500.h
+++ b/include/linux/mfd/abx500.h
@@ -229,4 +229,5 @@ struct abx500_ops {
};
int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
+void abx500_remove_ops(struct device *dev);
#endif
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Declare abx500_remove_ops()
2010-09-22 13:58 [PATCH] mfd: Declare abx500_remove_ops() Mark Brown
@ 2010-09-22 14:22 ` Mattias Wallin
2010-09-27 13:29 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Mattias Wallin @ 2010-09-22 14:22 UTC (permalink / raw)
To: Mark Brown
Cc: Samuel Ortiz, Linus WALLEIJ, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Thanks Mark!
I'll update the abxxx-core drivers to call the remove_ops in their exit functions.
/Wallin
On 09/22/2010 03:58 PM, Mark Brown wrote:
> Otherwise sparse warns about a public symbol with no declaration and
> the compiler can't spot if the callers and users have different signatures
> for the function.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/linux/mfd/abx500.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
> index be7373c..67bd6f7 100644
> --- a/include/linux/mfd/abx500.h
> +++ b/include/linux/mfd/abx500.h
> @@ -229,4 +229,5 @@ struct abx500_ops {
> };
>
> int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
> +void abx500_remove_ops(struct device *dev);
> #endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Declare abx500_remove_ops()
2010-09-22 13:58 [PATCH] mfd: Declare abx500_remove_ops() Mark Brown
2010-09-22 14:22 ` Mattias Wallin
@ 2010-09-27 13:29 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2010-09-27 13:29 UTC (permalink / raw)
To: Mark Brown; +Cc: Mattias Wallin, Linus Walleij, linux-kernel, patches
Hi Mark,
On Wed, Sep 22, 2010 at 02:58:30PM +0100, Mark Brown wrote:
> Otherwise sparse warns about a public symbol with no declaration and
> the compiler can't spot if the callers and users have different signatures
> for the function.
Patch applied, thanks for spotting this.
Cheers,
Samuel.
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/linux/mfd/abx500.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
> index be7373c..67bd6f7 100644
> --- a/include/linux/mfd/abx500.h
> +++ b/include/linux/mfd/abx500.h
> @@ -229,4 +229,5 @@ struct abx500_ops {
> };
>
> int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops);
> +void abx500_remove_ops(struct device *dev);
> #endif
> --
> 1.7.1
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-27 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-22 13:58 [PATCH] mfd: Declare abx500_remove_ops() Mark Brown
2010-09-22 14:22 ` Mattias Wallin
2010-09-27 13:29 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox