From: Andi Kleen <ak@linux.intel.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
Bernard Metzler <BMT@zurich.ibm.com>,
David Miller <davem@davemloft.net>,
Matthew Wilcox <willy@linux.intel.com>,
Roland Dreier <rdreier@cisco.com>
Subject: Re: [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel
Date: Wed, 22 Sep 2010 22:39:39 +0200 [thread overview]
Message-ID: <4C9A698B.90806@linux.intel.com> (raw)
In-Reply-To: <1285187425-10950-1-git-send-email-nab@linux-iscsi.org>
On 9/22/2010 10:30 PM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger<nab@linux-iscsi.org>
>
> This patch updates siw_create_qp() to check for the CONFIG_X86 + cpu_has_xmm4_2
> dependent use of the CRC32C instruction offload using libcrypto crc32c-intel.ko.
> This patch will by default use crc32c-intel when available, and fall back to the
> legacy slicing by 1x libcrypto crc32c.ko code when the instruction offload is not
> availabe.
I don't think every caller should handle checks like this. The crypto
layer should load the right driver
instead and provide the best driver under a generic algorithm name.
Need CPUID module auto probing. I have an older patch that needs some fixes.
-Andi
next prev parent reply other threads:[~2010-09-22 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 20:30 [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel Nicholas A. Bellinger
2010-09-22 20:39 ` Andi Kleen [this message]
2010-09-22 20:38 ` Nicholas A. Bellinger
2010-09-22 20:59 ` Jason Gunthorpe
2010-09-22 21:00 ` Nicholas A. Bellinger
2010-09-22 21:18 ` Jason Gunthorpe
2010-09-22 21:38 ` Nicholas A. Bellinger
2010-09-22 22:06 ` Jason Gunthorpe
2010-09-22 22:36 ` Nicholas A. Bellinger
2010-09-23 15:31 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9A698B.90806@linux.intel.com \
--to=ak@linux.intel.com \
--cc=BMT@zurich.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox