From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756777Ab0IXPKK (ORCPT ); Fri, 24 Sep 2010 11:10:10 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:64622 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496Ab0IXPKI (ORCPT ); Fri, 24 Sep 2010 11:10:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=VfLK8SzNw5J81qpPXtnvFwpnCXsE4QbuQ4mxiRBS61lr/gApwItkPA7usmJvTKpox6 0SYglqQs2pnlGA1J2mI8ZucyytBCo9NnvdSq7sa8f5PGJUyGJ+rr/uV30zj0ZTzzYF6k Uh4rwq39fluILM/p5jjX4YbDqsrvWleO40m2g= Message-ID: <4C9CBF4A.9060302@gmail.com> Date: Fri, 24 Sep 2010 18:10:02 +0300 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.9) Gecko/20100914 SUSE/3.1.4 Thunderbird/3.1.4 MIME-Version: 1.0 To: Don Zickus CC: Frederic Weisbecker , LKML , Linux-pm mailing list , linux-ide@vger.kernel.org Subject: Re: hibernation hangs with ATA errors (lockup_detector bug) References: <4C03C608.1040600@gmail.com> <20100601135004.GP15159@redhat.com> <4C051D44.7040203@gmail.com> <20100602184459.GA15159@redhat.com> <4C0B3E94.6020506@gmail.com> <4C80B338.6020701@gmail.com> <20100903135613.GV4879@redhat.com> In-Reply-To: <20100903135613.GV4879@redhat.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/2010 04:56 PM, Don Zickus wrote: > On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote: >> On 06/06/2010 08:22 AM, Jiri Slaby wrote: >>> On 06/02/2010 08:44 PM, Don Zickus wrote: >>>> --- a/kernel/watchdog.c >>>> +++ b/kernel/watchdog.c >>>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu) >>>> break; >>>> case CPU_ONLINE: >>>> case CPU_ONLINE_FROZEN: >>>> - if (watchdog_enable(hotcpu)) >>>> - return NOTIFY_BAD; >>>> + watchdog_enable(hotcpu) >>> >>> This fixes the problem indeed. >> >> Hi, was this fixed somehow? I still use this hunk and don't know if it >> is needed: > > I have to go re-review the problem again. I might have forgot to bring it > in. Thanks for reminding me! Reminder #2 :). Any updates? thanks, -- js