From: Avi Kivity <avi@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-users@vger.kernel.org
Subject: Re: [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate_insn
Date: Sun, 26 Sep 2010 11:35:54 +0200 [thread overview]
Message-ID: <4C9F13FA.9030405@redhat.com> (raw)
In-Reply-To: <1285298684.31083.6.camel@gandalf.stny.rr.com>
On 09/24/2010 05:24 AM, Steven Rostedt wrote:
> >
> > Note 2: I get output of the form
> >
> > ... kvm_emulate_insn: 0:fffff800010527b5: mov $0x0, 0xfffe00b0CAN'T FIND FIELD "guest_rip"
> >
> > which leads me to believe there is a bug in trace_seq_printf when the input
> > to %s is "".
>
> I ran this under gdb (nice to do that, where I don't in kernel :-) And
> it takes me to kvm_emulate_insn_handler() which does the
> trace_seq_printf() fine, but then calls pevent_print_num_field() and
> that passes in "guest_rip" where we get the "CAN'T FIND FIELD" error.
>
> In pevent_print_num_field() it searches for "guest_rip" at the top of
> the function (pevent_find_field()), but the event kvm_emulate_insn does
> not have a "guest_rip" field, then it jumps to the error message.
>
>
Gah, what idiot used copy-paste there?
I'll post a patch to remove that line.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-09-26 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 14:33 [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate_insn Avi Kivity
2010-09-20 9:51 ` Avi Kivity
2010-09-20 18:21 ` Steven Rostedt
2010-09-24 3:24 ` Steven Rostedt
2010-09-26 9:35 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9F13FA.9030405@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox