From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758618Ab0I0LBF (ORCPT ); Mon, 27 Sep 2010 07:01:05 -0400 Received: from mail.us.es ([193.147.175.20]:37674 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755670Ab0I0LBD (ORCPT ); Mon, 27 Sep 2010 07:01:03 -0400 Message-ID: <4CA0799E.4010200@netfilter.org> Date: Mon, 27 Sep 2010 13:01:50 +0200 From: Pablo Neira Ayuso User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100411 Icedove/3.0.4 MIME-Version: 1.0 To: Eric Paris CC: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, netfilter-devel@vger.kernel.org, jmorris@namei.org, sds@tycho.nsa.gov, jengelh@medozas.de, paul.moore@hp.com, casey@schaufler-ca.com, linux-security-module@vger.kernel.org, netfilter@vger.kernel.org, mr.dash.four@googlemail.com Subject: Re: [PATCH 5/6] conntrack: export lsm context rather than internal secid via netlink References: <20100924204517.28355.42822.stgit@paris.rdu.redhat.com> <20100924204545.28355.92767.stgit@paris.rdu.redhat.com> In-Reply-To: <20100924204545.28355.92767.stgit@paris.rdu.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/10 22:45, Eric Paris wrote: > @@ -172,4 +173,11 @@ enum ctattr_help { > }; > #define CTA_HELP_MAX (__CTA_HELP_MAX - 1) > > +enum ctattr_secctx { > + CTA_SECCTX_UNSPEC, > + CTA_SECCTX_NAME, > + __CTA_SECCTX_MAX > +}; > +#define CTA_SECCTX_MAX (__CTA_SECCTX_MAX - 1) I guess that you have included this nest for consistency with CTA_HELP. My question: do you think that we'll include more attributes in that nest in the future? Otherwise, I would remove that nest and put CTA_SECCTX_NAME in the first level, since the nest would increase the message size.