From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>, Tracey Dent <tdent48227@gmail.com>,
adilger.kernel@dilger.ca, jack@suse.cz, dmonakhov@openvz.org,
sandeen@redhat.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue
Date: Mon, 27 Sep 2010 08:52:38 -0500 [thread overview]
Message-ID: <4CA0A1A6.2050707@redhat.com> (raw)
In-Reply-To: <20100925235459.GA5299@thunk.org>
Ted Ts'o wrote:
> On Sat, Sep 25, 2010 at 02:31:52PM -0400, Tracey Dent wrote:
>> From: Tracey Dent <Tdent48227@gmail.com>
>>
>> Found and corrected indent issue using checkpatch.pl
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>
> Patches that fix whitespace issues aren't really worthwhile. They
> tend to cause extra work for the me as the maintainer, since it means
> that patches that others send me end up failing due to whitespace
> issues, which then have to be manually fixed up.
>
I second that sentiment, despite being guilty of similar patches
to other subsystems in the distant past ;) I've seen the light.
I would prefer that these not get merged.
-Eric
prev parent reply other threads:[~2010-09-27 13:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 18:31 [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Tracey Dent
2010-09-25 18:31 ` [PATCH 02/10] Fs: ext4: acl.h: whitespace cleanup Tracey Dent
2010-09-26 6:11 ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 03/10] Fs: ext: balloc: fixed a few issues that checkpatch.pl was having Tracey Dent
2010-09-25 18:31 ` [PATCH 04/10] Fs: ext4: block_validity: added space around = sign Tracey Dent
2010-09-25 18:31 ` [PATCH 05/10] Fs: ext4: ext4: cleaned up the file with checkpatch.pl Tracey Dent
2010-09-26 6:23 ` Krzysztof Halasa
2010-09-25 18:31 ` [PATCH 06/10] Fs: ext4: extents: whitespace cleanup Tracey Dent
2010-09-25 18:31 ` [PATCH 07/10] Fs: ext4: file: fixed indent problem Tracey Dent
2010-09-25 18:31 ` [PATCH 08/10] Fs: ext4: ioctl: fixed spacing issue Tracey Dent
2010-09-25 18:32 ` [PATCH 09/10] Fs: ext4: mballoc.c: whitespace cleanup Tracey Dent
2010-09-25 18:32 ` [PATCH 10/10] Fs: ext4: namei: fixed file of checkpatch/pl warnings and errors Tracey Dent
2010-09-26 6:36 ` Krzysztof Halasa
2010-09-26 18:23 ` Ted Ts'o
2010-09-26 18:35 ` Davidlohr Bueso
2010-09-26 19:17 ` Krzysztof Halasa
2010-09-25 23:36 ` [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Christoph Hellwig
2010-09-25 23:53 ` T Dent
2010-09-25 23:56 ` Christoph Hellwig
2010-09-26 0:01 ` Ted Ts'o
2010-09-26 0:09 ` Joe Perches
2010-09-26 0:32 ` Ted Ts'o
2010-09-26 0:36 ` Ted Ts'o
2010-09-26 0:50 ` Joe Perches
2010-09-26 0:58 ` Joe Perches
2010-09-26 6:42 ` Krzysztof Halasa
2010-09-26 6:49 ` Joe Perches
2010-09-26 11:31 ` Krzysztof Halasa
2010-09-26 1:04 ` Ted Ts'o
2010-09-26 1:32 ` Joe Perches
2010-09-26 1:53 ` Ted Ts'o
2010-09-26 2:03 ` Joe Perches
2010-09-26 2:10 ` Ted Ts'o
2010-09-26 2:21 ` Ted Ts'o
2010-09-26 2:45 ` Joe Perches
2010-09-26 2:29 ` Joe Perches
2010-09-26 0:06 ` Joe Perches
2010-09-26 20:06 ` Christoph Hellwig
2010-09-26 22:17 ` Joe Perches
2010-09-25 23:54 ` Ted Ts'o
2010-09-27 13:52 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA0A1A6.2050707@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox