From: Greg Ungerer <gerg@snapgear.com>
To: matt mooney <mfm@muteddisk.com>
Cc: Greg Ungerer <gerg@uclinux.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Tim Abbott <tabbott@ksplice.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 08/20] m68knommu: change to new flag variables
Date: Tue, 28 Sep 2010 16:41:04 +1000 [thread overview]
Message-ID: <4CA18E00.7090207@snapgear.com> (raw)
In-Reply-To: <1285224645-29728-1-git-send-email-mfm@muteddisk.com>
Hi Matt,
On 23/09/10 16:50, matt mooney wrote:
> Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.
>
> Signed-off-by: matt mooney<mfm@muteddisk.com>
Looks fine to me. Are you looking for this to go through
maintainer trees, or the whole patch series in one go?
Acked-by: Greg Ungerer <gerg@uclinux.org>
Regards
Greg
> ---
> arch/m68knommu/platform/5206/Makefile | 4 ++--
> arch/m68knommu/platform/5206e/Makefile | 4 ++--
> arch/m68knommu/platform/520x/Makefile | 4 ++--
> arch/m68knommu/platform/523x/Makefile | 4 ++--
> arch/m68knommu/platform/5249/Makefile | 4 ++--
> arch/m68knommu/platform/5272/Makefile | 4 ++--
> arch/m68knommu/platform/527x/Makefile | 4 ++--
> arch/m68knommu/platform/528x/Makefile | 4 ++--
> arch/m68knommu/platform/5307/Makefile | 4 ++--
> arch/m68knommu/platform/532x/Makefile | 4 ++--
> arch/m68knommu/platform/5407/Makefile | 4 ++--
> arch/m68knommu/platform/coldfire/Makefile | 4 ++--
> 12 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/arch/m68knommu/platform/5206/Makefile b/arch/m68knommu/platform/5206/Makefile
> index 113c333..b5db056 100644
> --- a/arch/m68knommu/platform/5206/Makefile
> +++ b/arch/m68knommu/platform/5206/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/5206e/Makefile b/arch/m68knommu/platform/5206e/Makefile
> index 113c333..b5db056 100644
> --- a/arch/m68knommu/platform/5206e/Makefile
> +++ b/arch/m68knommu/platform/5206e/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/520x/Makefile b/arch/m68knommu/platform/520x/Makefile
> index 435ab34..ad3f4e5 100644
> --- a/arch/m68knommu/platform/520x/Makefile
> +++ b/arch/m68knommu/platform/520x/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/523x/Makefile b/arch/m68knommu/platform/523x/Makefile
> index b8f9b45..c04b8f7 100644
> --- a/arch/m68knommu/platform/523x/Makefile
> +++ b/arch/m68knommu/platform/523x/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/5249/Makefile b/arch/m68knommu/platform/5249/Makefile
> index f56225d..4bed30f 100644
> --- a/arch/m68knommu/platform/5249/Makefile
> +++ b/arch/m68knommu/platform/5249/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/5272/Makefile b/arch/m68knommu/platform/5272/Makefile
> index 93673ef..34110fc 100644
> --- a/arch/m68knommu/platform/5272/Makefile
> +++ b/arch/m68knommu/platform/5272/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/527x/Makefile b/arch/m68knommu/platform/527x/Makefile
> index 3d90e6d..6ac4b57 100644
> --- a/arch/m68knommu/platform/527x/Makefile
> +++ b/arch/m68knommu/platform/527x/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/528x/Makefile b/arch/m68knommu/platform/528x/Makefile
> index 3d90e6d..6ac4b57 100644
> --- a/arch/m68knommu/platform/528x/Makefile
> +++ b/arch/m68knommu/platform/528x/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/5307/Makefile b/arch/m68knommu/platform/5307/Makefile
> index 6de5269..d4293b7 100644
> --- a/arch/m68knommu/platform/5307/Makefile
> +++ b/arch/m68knommu/platform/5307/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/532x/Makefile b/arch/m68knommu/platform/532x/Makefile
> index 4cc2324..ce01669 100644
> --- a/arch/m68knommu/platform/532x/Makefile
> +++ b/arch/m68knommu/platform/532x/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/5407/Makefile b/arch/m68knommu/platform/5407/Makefile
> index dee62c5..e83fe14 100644
> --- a/arch/m68knommu/platform/5407/Makefile
> +++ b/arch/m68knommu/platform/5407/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
> diff --git a/arch/m68knommu/platform/coldfire/Makefile b/arch/m68knommu/platform/coldfire/Makefile
> index f72a0e5..788c13f 100644
> --- a/arch/m68knommu/platform/coldfire/Makefile
> +++ b/arch/m68knommu/platform/coldfire/Makefile
> @@ -8,8 +8,8 @@
> # on the console port whenever a DBG interrupt occurs. You have to
> # set up you HW breakpoints to trigger a DBG interrupt:
> #
> -# EXTRA_CFLAGS += -DTRAP_DBG_INTERRUPT
> -# EXTRA_AFLAGS += -DTRAP_DBG_INTERRUPT
> +# ccflags-y := -DTRAP_DBG_INTERRUPT
> +# asflags-y := -DTRAP_DBG_INTERRUPT
> #
>
> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
next prev parent reply other threads:[~2010-09-28 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 6:50 [PATCH 08/20] m68knommu: change to new flag variables matt mooney
2010-09-28 6:41 ` Greg Ungerer [this message]
2010-09-28 7:16 ` matt mooney
2010-09-28 13:22 ` Greg Ungerer
2010-09-29 14:36 ` Michal Marek
2010-09-29 23:15 ` matt mooney
2010-09-30 20:51 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA18E00.7090207@snapgear.com \
--to=gerg@snapgear.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfm@muteddisk.com \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox