Re: [PATCH 4/8] v2 Allow memory block to span multiple memory sections

Nathan Fontenot
2010-09-28T18:21:34Z

On 09/28/2010 07:48 AM, Robin Holt wrote:
>> +u32 __weak memory_block_size_bytes(void)
>> +{
>> + return MIN_MEMORY_BLOCK_SIZE;
>> +}
>> +
>> +static u32 get_memory_block_size(void)
>
> Can we make this an unsigned long? We are testing on a system whose
> smallest possible configuration is 4GB per socket with 512 sockets.
> We would like to be able to specify this as 2GB by default (results
> in the least lost memory) and suggest we add a command line option
> which overrides this value. We have many installations where 16GB may
> be optimal. Large configurations will certainly become more prevalent.

Works for me.

>
> ...
>> @@ -551,12 +608,16 @@
>> unsigned int i;
>> int ret;
>> int err;
>> + int block_sz;
>
> This one needs to match the return above. In our tests, we ended up
> with a negative sections_per_block which caused very unexpected results.

Oh, nice catch. I'll update both of these.

-Nathan