From: Michael Cree <mcree@orcon.net.nz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org, mattst88@gmail.com,
torvalds@linux-foundation.org, linux-alpha@vger.kernel.org
Subject: Re: [PATCH 1/2] alpha: switch osf_sigprocmask() to use of sigprocmask()
Date: Thu, 30 Sep 2010 20:39:01 +1300 [thread overview]
Message-ID: <4CA43E95.5040301@orcon.net.nz> (raw)
In-Reply-To: <20100929010738.GJ19804@ZenIV.linux.org.uk>
On 29/09/10 14:07, Al Viro wrote:
> On Tue, Sep 28, 2010 at 10:39:43PM +1300, Michael Cree wrote:
>> On 27/09/10 07:28, Al Viro wrote:
>>>
>>> get rid of a useless wrapper, while we are at it
>>>
>>> Signed-off-by: Al Viro<viro@zeniv.linux.org.uk>
>>
>> Compiling this leads to the following errors:
>
> Grrrr.... My apologies - cherry-pick from the wrong branch ;-/
>
> Al "nothing like seeing the errors one has fixed show up in what's sent" Viro
It appears to be worse than that. It introduces a regression. On boot
up on a Compaq Alpha XP1000 the system appears to freeze at the point of
mounting swap. It eventually resumes after almost three minutes and
continues to boot. A bisection returned this very commit as the first
bad commit. With a kernel without this commit the (truncated) bootup
log is:
[ 19.904286] ftdi_sio: v1.6.0:USB FTDI Serial Converters Driver
[ 20.133778] PCI: Setting latency timer of device 0000:01:00.1 to 64
[ 20.900379] ieee1394: Host added: ID:BUS[0-00:1023]
GUID[0000303c0009c6d0]
[ 23.142566] hda-intel: azx_get_response timeout, switching to polling
mode: last cmd=0x000f0001
[ 24.162097] Adding 1999992k swap on /dev/sda2. Priority:-1 extents:1
across:1999992k
[ 24.495104] EXT3-fs (sda4): using internal journal
With the commit the log becomes:
[ 19.970692] ftdi_sio: v1.6.0:USB FTDI Serial Converters Driver
[ 20.207020] PCI: Setting latency timer of device 0000:01:00.1 to 64
[ 21.052723] ieee1394: Host added: ID:BUS[0-00:1023]
GUID[0000303c0009c6d0]
[ 23.215808] hda-intel: azx_get_response timeout, switching to polling
mode: last cmd=0x000f0001
[ 189.828027] Adding 1999992k swap on /dev/sda2. Priority:-1 extents:1
across:1999992k
[ 190.162012] EXT3-fs (sda4): using internal journal
Otherwise the system seems to come up okay.
Cheers
Michael.
next prev parent reply other threads:[~2010-09-30 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 18:28 [PATCH 1/2] alpha: switch osf_sigprocmask() to use of sigprocmask() Al Viro
2010-09-28 9:39 ` Michael Cree
2010-09-29 1:07 ` Al Viro
2010-09-30 7:39 ` Michael Cree [this message]
2010-09-30 11:50 ` Al Viro
2010-09-30 11:56 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA43E95.5040301@orcon.net.nz \
--to=mcree@orcon.net.nz \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox