From: "H. Peter Anvin" <hpa@zytor.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Avinash Kurup <kurup.avinash@gmail.com>
Subject: Re: [PATCH] Skip looking for ioapic overrides when ioapics are not present
Date: Thu, 30 Sep 2010 15:56:42 -0700 [thread overview]
Message-ID: <4CA515AA.7060400@zytor.com> (raw)
In-Reply-To: <m17hmcke5m.fsf@fess.ebiederm.org>
On 06/05/2010 08:56 PM, Eric W. Biederman wrote:
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 33f3563..226a6d1 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -4066,6 +4066,9 @@ int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity)
> {
> int ioapic, pin, idx;
>
> + if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
> + return -1;
> +
> if (skip_ioapic_setup)
> return -1;
>
I was just poked about this patch... it doesn't build "make allnoconfig"
on x86-64.
This is also a bugzilla ticket now:
https://bugzilla.kernel.org/show_bug.cgi?id=17772
-hpa
next prev parent reply other threads:[~2010-09-30 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTilT0cPU8y2m4ZeatfvtflAagSyQEP9JubqZ6TeW@mail.gmail.com>
2010-06-03 9:08 ` ERROR: Unable to locate IOAPIC for GSI xx Eric W. Biederman
2010-06-06 3:56 ` [PATCH] Skip looking for ioapic overrides when ioapics are not present Eric W. Biederman
2010-09-30 22:56 ` H. Peter Anvin [this message]
2010-10-02 14:45 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA515AA.7060400@zytor.com \
--to=hpa@zytor.com \
--cc=ebiederm@xmission.com \
--cc=kurup.avinash@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox