From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519Ab0JCMuu (ORCPT ); Sun, 3 Oct 2010 08:50:50 -0400 Received: from mx01.sz.bfs.de ([194.94.69.103]:28253 "EHLO mx01.sz.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324Ab0JCMut (ORCPT ); Sun, 3 Oct 2010 08:50:49 -0400 Message-ID: <4CA87C24.8040403@bfs.de> Date: Sun, 03 Oct 2010 14:50:44 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: Tracey Dent CC: greg@kroah.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, sam@ravnborg.org Subject: Re: [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile cflag lines References: <1286037489-28439-1-git-send-email-tdent48227@gmail.com> <1286037489-28439-13-git-send-email-tdent48227@gmail.com> In-Reply-To: <1286037489-28439-13-git-send-email-tdent48227@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tracey Dent schrieb: > Changed to use the proper ccflags-y option > > Signed-off-by: Tracey Dent > --- > drivers/staging/rtl8192u/Makefile | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile > index 738f4a8..cba4344 100644 > --- a/drivers/staging/rtl8192u/Makefile > +++ b/drivers/staging/rtl8192u/Makefile > @@ -1,16 +1,16 @@ > NIC_SELECT = RTL8192U > > -EXTRA_CFLAGS += -std=gnu89 > -EXTRA_CFLAGS += -O2 > +ccflags-y := -std=gnu89 > +ccflags-y += -O2 > no optimisation please, > -EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y these CONFIG_FORCE_HARD_FLOAT again, why do they call it config when they need it ? re, wh > -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX > -EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO > -#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE > -#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT > -EXTRA_CFLAGS += -DUSE_ONE_PIPE > -EXTRA_CFLAGS += -DENABLE_DOT11D > -EXTRA_CFLAGS += -Idrivers/staging/rtl8192u/ieee80211 > +ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y > +ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX > +ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO > +#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE > +#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT > +ccflags-y += -DUSE_ONE_PIPE > +ccflags-y += -DENABLE_DOT11D > +ccflags-y += -Idrivers/staging/rtl8192u/ieee80211 > > r8192u_usb-objs := r8192U_core.o r8180_93cx6.o r8192U_wx.o \ > r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o \