From: walter harms <wharms@bfs.de>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, sam@ravnborg.org
Subject: Re: [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned up Makefile cflag lines
Date: Sun, 03 Oct 2010 15:06:14 +0200 [thread overview]
Message-ID: <4CA87FC6.40208@bfs.de> (raw)
In-Reply-To: <1286037489-28439-14-git-send-email-tdent48227@gmail.com>
Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/Makefile | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/Makefile b/drivers/staging/rtl8192u/ieee80211/Makefile
> index 71ca5d9..45704f8 100644
> --- a/drivers/staging/rtl8192u/ieee80211/Makefile
> +++ b/drivers/staging/rtl8192u/ieee80211/Makefile
> @@ -5,22 +5,22 @@ MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/$(NIC_SELECT)
>
> CC = gcc
does this mean we can compile with gcc only ? where are the icc users ?
> ifneq ($(shell uname -r|cut -d. -f1,2), 2.4)
I can guess what the author intended but this will only check *on*
what system i am compiling, not what linux version i try *to conpile*.
see: KERNEL_VERSION macro
> -EXTRA_CFLAGS += -I$(TOPDIR)/drivers/net/wireless
> -EXTRA_CFLAGS += -O2
no optimisation, please
> -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> +ccflags-y := -I$(TOPDIR)/drivers/net/wireless
> +ccflags-y += -O2
> +ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
>
> #it will fail to compile in suse linux enterprise 10 sp2. This flag is to solve this problem.
> ifeq ($(shell uname -r | cut -d. -f1,2,3,4), 2.6.16.60-0)
> -EXTRA_CFLAGS += -DOPENSUSE_SLED
> +ccflags-y := -DOPENSUSE_SLED
> endif
this should be something like .....
# if LINUX_VERSION_CODE = KERNEL_VERSION(2,6,16)
#define OPENSUSE_SLED
#endif
> ifeq ($(NIC_SELECT),RTL8192U)
> -#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> -#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
> +#ccflags-y := -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> +#ccflags-y := -DUSB_RX_AGGREGATION_SUPPORT
> endif
> -#EXTRA_CFLAGS += -DJOHN_NOCPY
> +#ccflags-y := -DJOHN_NOCPY
> #flags to enable or disble 80211D feature
> -EXTRA_CFLAGS += -DENABLE_DOT11D
> +ccflags-y += -DENABLE_DOT11D
> ieee80211-rsl-objs := ieee80211_rx.o \
> ieee80211_softmac.o \
> ieee80211_tx.o \
just my 2 cents,
wh
next prev parent reply other threads:[~2010-10-03 13:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 16:37 [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-02 16:37 ` [PATCH v3 02/20] Staging: cxt1e1: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 03/20] Staging: dream: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 04/20] Staging: dream: camera: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 05/20] Staging: dream: qdsp5: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 06/20] Stagng: easycap: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 07/20] Staging: rt2860: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 08/20] Staging: rt2870: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 09/20] Staging: rtl8187se: " Tracey Dent
2010-10-03 12:47 ` walter harms
2010-10-02 16:37 ` [PATCH v3 10/20] Staging: rtl8192e: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 11/20] Staging: rtl8192su: " Tracey Dent
2010-10-03 12:42 ` walter harms
2010-10-03 13:39 ` T Dent
2010-10-05 19:02 ` Greg KH
2010-10-02 16:38 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: " Tracey Dent
2010-10-03 12:48 ` walter harms
2010-10-05 19:02 ` Greg KH
2010-10-05 21:47 ` T Dent
2010-10-05 21:51 ` T Dent
2010-10-05 22:20 ` Greg KH
2010-10-02 16:38 ` [PATCH v3 13/20] Staging: rtl8192u: " Tracey Dent
2010-10-03 12:50 ` walter harms
2010-10-02 16:38 ` [PATCH v3 14/20] Staging: rtl8192u: ieee80211: " Tracey Dent
2010-10-03 13:06 ` walter harms [this message]
2010-10-02 16:38 ` [PATCH v3 15/20] Staging: tm6000: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 16/20] Staging: usbip: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 17/20] Staging: vt6655: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 18/20] Staging: vt6656: " Tracey Dent
2010-10-03 13:09 ` walter harms
2010-10-02 16:38 ` [PATCH v3 19/20] Staging: wlags49_h2: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 20/20] Staging: wlags49_h25: " Tracey Dent
2010-10-03 12:40 ` [PATCH v3 01/20] Staging: cx25821: " walter harms
2010-10-03 20:51 ` Sam Ravnborg
2010-10-05 5:35 ` matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA87FC6.40208@bfs.de \
--to=wharms@bfs.de \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox