From: Thomas Dahlmann <dahlmann.thomas@arcor.de>
To: Rahul Ruikar <rahul.ruikar@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-geode@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: amd5536udc: Fix error path
Date: Mon, 04 Oct 2010 14:15:45 +0200 [thread overview]
Message-ID: <4CA9C571.3070909@arcor.de> (raw)
In-Reply-To: <1286003420-3774-1-git-send-email-rahul.ruikar@gmail.com>
ACK
Thanks for the fix!
Thomas
On 10/2/2010 9:10 AM, Rahul Ruikar wrote:
> In function udc_probe()
> call put_device() when device_register() fails.
>
> Signed-off-by: Rahul Ruikar<rahul.ruikar@gmail.com>
> ---
> drivers/usb/gadget/amd5536udc.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index 731150d4..950ee33 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -3382,8 +3382,10 @@ static int udc_probe(struct udc *dev)
> udc = dev;
>
> retval = device_register(&dev->gadget.dev);
> - if (retval)
> + if (retval) {
> + put_device(&dev->gadget.dev);
> goto finished;
> + }
>
> /* timer init */
> init_timer(&udc_timer);
>
prev parent reply other threads:[~2010-10-04 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 7:10 [PATCH] usb: gadget: amd5536udc: Fix error path Rahul Ruikar
2010-10-04 12:15 ` Thomas Dahlmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9C571.3070909@arcor.de \
--to=dahlmann.thomas@arcor.de \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rahul.ruikar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox