* [PATCH] usb: gadget: amd5536udc: Fix error path
@ 2010-10-02 7:10 Rahul Ruikar
2010-10-04 12:15 ` Thomas Dahlmann
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Ruikar @ 2010-10-02 7:10 UTC (permalink / raw)
To: Thomas Dahlmann, David Brownell, Greg Kroah-Hartman,
Andrew Morton
Cc: linux-geode, linux-usb, linux-kernel, Rahul Ruikar
In function udc_probe()
call put_device() when device_register() fails.
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/usb/gadget/amd5536udc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index 731150d4..950ee33 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -3382,8 +3382,10 @@ static int udc_probe(struct udc *dev)
udc = dev;
retval = device_register(&dev->gadget.dev);
- if (retval)
+ if (retval) {
+ put_device(&dev->gadget.dev);
goto finished;
+ }
/* timer init */
init_timer(&udc_timer);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: gadget: amd5536udc: Fix error path
2010-10-02 7:10 [PATCH] usb: gadget: amd5536udc: Fix error path Rahul Ruikar
@ 2010-10-04 12:15 ` Thomas Dahlmann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Dahlmann @ 2010-10-04 12:15 UTC (permalink / raw)
To: Rahul Ruikar
Cc: David Brownell, Greg Kroah-Hartman, Andrew Morton, linux-geode,
linux-usb, linux-kernel
ACK
Thanks for the fix!
Thomas
On 10/2/2010 9:10 AM, Rahul Ruikar wrote:
> In function udc_probe()
> call put_device() when device_register() fails.
>
> Signed-off-by: Rahul Ruikar<rahul.ruikar@gmail.com>
> ---
> drivers/usb/gadget/amd5536udc.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index 731150d4..950ee33 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -3382,8 +3382,10 @@ static int udc_probe(struct udc *dev)
> udc = dev;
>
> retval = device_register(&dev->gadget.dev);
> - if (retval)
> + if (retval) {
> + put_device(&dev->gadget.dev);
> goto finished;
> + }
>
> /* timer init */
> init_timer(&udc_timer);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-04 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-02 7:10 [PATCH] usb: gadget: amd5536udc: Fix error path Rahul Ruikar
2010-10-04 12:15 ` Thomas Dahlmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox