From: "H. Peter Anvin" <hpa@zytor.com>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Beulich <JBeulich@novell.com>, Ingo Molnar <mingo@elte.hu>,
heukelum@fastmail.fm, tglx@linutronix.de,
akpm@linux-foundation.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: gas 2.16 and assembly macros -- entry_64.S build failure
Date: Mon, 04 Oct 2010 11:23:31 -0700 [thread overview]
Message-ID: <4CAA1BA3.1010306@zytor.com> (raw)
In-Reply-To: <4CA9FEE2.7000900@redhat.com>
On 10/04/2010 09:20 AM, Avi Kivity wrote:
> On 10/04/2010 05:43 PM, H. Peter Anvin wrote:
>> On 10/04/2010 03:04 AM, Avi Kivity wrote:
>>> On 10/01/2010 02:26 AM, H. Peter Anvin wrote:
>>>> ... but that doesn't work with the macros like movq_cfi. On those, we
>>>> could argue that at least people won't put $ on them, but cpp will still
>>>> split them apart with spaces; this apparently causes problems at least
>>>> as soon as there is an expression more complicated than addition
>>>> involved (apparently plus signs are okay, but minus signs aren't!)
>>>
>>> Likely due to the fact that a minus sign can later join with a number
>>> and become a new token, but a plug sign cannot.
>>>
>>
>> ... except the same thing applies to other operators, other than the
>> plus sign. This kind of characterization is insanely frustrating, and
>> really doesn't seem to follow logical rules ... we had a previous one
>> where changing a macro name from upper case to lower case made gas 2.16
>> work...
>>
>
> Well, / and * do join. % doesn't. In a way, + does.
>
> cpp is not a pure text processing language. It's specifically geared to
> C, and is fairly creaky when applying it to something other than C (and
> is only somewhat creaky when applying it to C).
>
The problem isn't with cpp, though, it's with gas. There are bugs in
the gas 2.16 macro features that don't apply to any other gas version,
before *or* after.
-hpa
next prev parent reply other threads:[~2010-10-04 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201009152110.o8FLAJeJ015584@imap1.linux-foundation.org>
[not found] ` <4C91F07E0200007800016B50@vpn.id2.novell.com>
[not found] ` <20100916082816.GA25681@elte.hu>
[not found] ` <4C91F3A30200007800016B64@vpn.id2.novell.com>
[not found] ` <20100916101355.GA31458@elte.hu>
[not found] ` <4C9219BC0200007800016C53@vpn.id2.novell.com>
2010-10-01 0:26 ` gas 2.16 and assembly macros -- entry_64.S build failure H. Peter Anvin
2010-10-01 1:01 ` Andrew Morton
2010-10-01 1:48 ` H. Peter Anvin
2010-10-01 8:27 ` Jan Beulich
2010-10-01 15:21 ` H. Peter Anvin
2010-10-01 15:46 ` Jan Beulich
2010-10-01 17:21 ` H. Peter Anvin
2010-10-04 7:36 ` Jan Beulich
2010-10-04 10:04 ` Avi Kivity
2010-10-04 15:43 ` H. Peter Anvin
2010-10-04 16:20 ` Avi Kivity
2010-10-04 18:23 ` H. Peter Anvin [this message]
2010-10-05 7:48 ` Avi Kivity
2010-10-05 7:51 ` Ingo Molnar
2010-10-05 9:09 ` Avi Kivity
2010-10-19 10:13 ` Jan Beulich
2010-10-19 10:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAA1BA3.1010306@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=heukelum@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox