From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757314Ab0JDVWt (ORCPT ); Mon, 4 Oct 2010 17:22:49 -0400 Received: from terminus.zytor.com ([198.137.202.10]:53850 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757293Ab0JDVWs (ORCPT ); Mon, 4 Oct 2010 17:22:48 -0400 Message-ID: <4CAA455D.8000902@zytor.com> Date: Mon, 04 Oct 2010 14:21:33 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Thunderbird/3.1.4 MIME-Version: 1.0 To: Linus Torvalds CC: Borislav Petkov , Ingo Molnar , Thomas Gleixner , lkml Subject: Re: [PATCH] x86, cpu: Fix X86_FEATURE_NOPL References: <20101003093701.GB3733@liondog.tnic> <4CA89681.8000202@zytor.com> <20101003152212.GA13233@liondog.tnic> <20101003201139.GA16532@liondog.tnic> <20101004073127.GA20305@liondog.tnic> <4CAA4102.3070205@zytor.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2010 02:12 PM, Linus Torvalds wrote: > On Mon, Oct 4, 2010 at 2:02 PM, H. Peter Anvin wrote: >> >> Actually, cpu_has() depends on: >> #if defined(CONFIG_X86_P6_NOP) || defined(CONFIG_X86_64) > > Ahh. Right you are. The place that depends on just P6_NOP is the > default NOP choice logic in > > But the end result ends up being the same: can we please clean this > all up so that it isn't so confusing? Rather than add to the > confusion? > Agreed that this should be cleaned up. However, in the meantime I'd like to keep Borislav's patch in the tree since it makes the code technically correct at least. OK? -hpa