From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, cpu: Fix X86_FEATURE_NOPL
Date: Mon, 04 Oct 2010 14:53:15 -0700 [thread overview]
Message-ID: <4CAA4CCB.5090205@zytor.com> (raw)
In-Reply-To: <20101004214838.GA26084@liondog.tnic>
On 10/04/2010 02:48 PM, Borislav Petkov wrote:
>
> I think the cleanup should be easy: on 64-bit unconditionally return
> p6_nops in find_nop_table() since every 64-bit processor should support
> them and on 32-bit never return p6_nops since X86_FEATURE_NOPL is not
> set there and fall back to intel_nops on non-AMD. Which means we can get
> rid of X86_FEATURE_NOPL altogether. Too radical?
>
FWIW, if P6_NOPs work as well as 66...90 on AMD, I'd much rather switch
to the fixed sequence for all 64-bit processors.
-hpa
next prev parent reply other threads:[~2010-10-04 21:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 9:37 NOPL on 32-bit Borislav Petkov
2010-10-03 14:43 ` H. Peter Anvin
2010-10-03 15:22 ` [PATCH] x86, cpu: X86_FEATURE_NOPL should be disabled on 32-bit only Borislav Petkov
2010-10-03 18:19 ` H. Peter Anvin
2010-10-03 20:11 ` Borislav Petkov
2010-10-03 22:22 ` H. Peter Anvin
2010-10-04 7:31 ` [PATCH] x86, cpu: Fix X86_FEATURE_NOPL Borislav Petkov
2010-10-04 20:36 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-10-05 9:47 ` Borislav Petkov
2010-10-05 16:30 ` H. Peter Anvin
2010-10-05 16:53 ` Borislav Petkov
2010-10-04 20:47 ` [PATCH] " Linus Torvalds
2010-10-04 21:02 ` H. Peter Anvin
2010-10-04 21:12 ` Linus Torvalds
2010-10-04 21:21 ` H. Peter Anvin
2010-10-04 21:48 ` Borislav Petkov
2010-10-04 21:50 ` H. Peter Anvin
2010-10-04 21:53 ` H. Peter Anvin [this message]
2010-10-05 6:19 ` Borislav Petkov
2010-10-04 22:17 ` Hugh Dickins
2010-10-04 22:19 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAA4CCB.5090205@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox