From: Michal Marek <mmarek@suse.cz>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: Fix Kconfig dependencies
Date: Tue, 05 Oct 2010 00:01:02 +0200 [thread overview]
Message-ID: <4CAA4E9E.8040002@suse.cz> (raw)
In-Reply-To: <20101004180346.59b10af7@endymion.delvare>
On 4.10.2010 18:03, Jean Delvare wrote:
> You have bad luck, I'm afraid. Sure, most users do not unset
> I2C_HELPER_AUTO, so they will not see the extra entries in the main I2C
> menu, however _I_ unset it and guess what, _I_ am the one deciding
> whether your patch can be applied or not ;)
OK :).
>> Please consider for 2.6.36, as the warning is caused by a kconfig fix
>> that I'm about to send to Linus for 2.6.36. And it is triggered by a
>> simple 'make defconfig' in i386/x84_64:
>
> You should reconsider then. Kernel 2.6.36 will be released in a few
> days, is your fix so important that it has to go in, even when you have
> evidence that it breaks other parts of the configuration, which in turn
> will have to be fixed?
To clarify: The kconfig fix does not "break" anything. It just correctly
warns in cases where it previously did not spot a broken dependency. My
patch was just a means to silence a warning, nothing more.
Michal
next prev parent reply other threads:[~2010-10-04 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 13:31 [PATCH] i2c: Fix Kconfig dependencies Michal Marek
2010-10-04 16:03 ` Jean Delvare
2010-10-04 22:01 ` Michal Marek [this message]
2010-10-04 22:30 ` Michal Marek
2010-10-05 8:03 ` Jean Delvare
2010-10-05 15:56 ` Michal Marek
2010-10-07 13:24 ` Jean Delvare
2010-10-07 13:37 ` Michal Marek
2010-10-07 13:48 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAA4E9E.8040002@suse.cz \
--to=mmarek@suse.cz \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox