From: Chris Metcalf <cmetcalf@tilera.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>
Subject: Re: [PATCH 1/2] bitops: make asm-generic/bitops/find.h more generic
Date: Tue, 5 Oct 2010 08:25:52 -0400 [thread overview]
Message-ID: <4CAB1950.8060103@tilera.com> (raw)
In-Reply-To: <1285751331-29148-1-git-send-email-akinobu.mita@gmail.com>
On 9/29/2010 5:08 AM, Akinobu Mita wrote:
> asm-generic/bitops/find.h has the extern declarations of find_next_bit()
> and find_next_zero_bit() and the macro definitions of find_first_bit()
> and find_first_zero_bit(). It is only usable by the architectures which
> enables CONFIG_GENERIC_FIND_NEXT_BIT and disables
> CONFIG_GENERIC_FIND_FIRST_BIT.
>
> x86 and tile enable both CONFIG_GENERIC_FIND_NEXT_BIT and
> CONFIG_GENERIC_FIND_FIRST_BIT. These architectures cannot include
> asm-generic/bitops/find.h in their asm/bitops.h. So ifdefed extern
> declarations of find_first_bit and find_first_zero_bit() are put in
> linux/bitops.h.
>
> This makes asm-generic/bitops/find.h usable by these architectures
> and use it. Also this change is needed for the forthcoming duplicated
> extern declarations cleanup.
This looks good, thanks.
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2010-10-05 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 9:08 [PATCH 1/2] bitops: make asm-generic/bitops/find.h more generic Akinobu Mita
2010-09-29 9:08 ` [PATCH 2/2] bitops: remove duplicated extern declarations Akinobu Mita
2010-10-05 12:25 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAB1950.8060103@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox