From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Rahul Ruikar <rahul.ruikar@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Joe Perches <joe@perches.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: langwell_udc: Fix error path
Date: Tue, 05 Oct 2010 23:17:24 +0400 [thread overview]
Message-ID: <4CAB79C4.3030208@ru.mvista.com> (raw)
In-Reply-To: <1286302800-2715-1-git-send-email-rahul.ruikar@gmail.com>
Hello.
Rahul Ruikar wrote:
> Fix for following cases
> - Call device_unregister() only when device_register() is success.
s/is success/succeeds/
> - Call put_device() when device_register() fails.
> - Call device_remove_file() only when device_create_file() is success.
s/is success/succeeds/
> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
[...]
> diff --git a/drivers/usb/gadget/langwell_udc.h b/drivers/usb/gadget/langwell_udc.h
> index 9719934..b212a70 100644
> --- a/drivers/usb/gadget/langwell_udc.h
> +++ b/drivers/usb/gadget/langwell_udc.h
> @@ -199,7 +199,9 @@ struct langwell_udc {
> vbus_active:1,
> suspended:1,
> stopped:1,
> - lpm:1; /* LPM capability */
> + lpm:1, /* LPM capability */
> + reg_status:1,
> + file_create:1;
I'd rather have called this 'file_created'.
>
> /* pci state used to access those endpoints */
> struct pci_dev *pdev;
WBR, Sergei
next prev parent reply other threads:[~2010-10-05 19:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 18:20 [PATCH] usb: gadget: langwell_udc: Fix error path Rahul Ruikar
2010-10-05 19:17 ` Sergei Shtylyov [this message]
2010-10-06 2:34 ` Rahul Ruikar
2010-10-06 20:21 ` Greg KH
2010-10-07 3:55 ` Rahul Ruikar
-- strict thread matches above, loose matches on Subject: below --
2010-10-07 3:52 Rahul Ruikar
2010-10-07 3:54 ` Rahul Ruikar
2010-10-07 17:51 ` Greg KH
2010-10-07 18:19 ` Rahul Ruikar
2010-10-07 20:48 ` Greg KH
2010-10-03 13:49 Rahul Ruikar
2010-10-04 10:44 ` Sergei Shtylyov
2010-10-04 10:52 ` Rahul Ruikar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAB79C4.3030208@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rahul.ruikar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox